Attention is currently required from: Nico Huber, Arthur Heymans, Patrick Rudolph. Hello Nico Huber, Arthur Heymans, Patrick Rudolph,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/55689
to review the following change.
Change subject: nb/intel/haswell/pcie.c: Introduce helper variable ......................................................................
nb/intel/haswell/pcie.c: Introduce helper variable
Introduce a helper variable to avoid some redundancy and to reduce the diffstat noise in follow-up changes.
Tested with BUILD_TIMELESS=1, Asrock B85M Pro4 remains identical.
Change-Id: I490675aaddd2b5a13d990664431f79a605999254 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/pcie.c 1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/55689/1
diff --git a/src/northbridge/intel/haswell/pcie.c b/src/northbridge/intel/haswell/pcie.c index 2cd80be..4806f77 100644 --- a/src/northbridge/intel/haswell/pcie.c +++ b/src/northbridge/intel/haswell/pcie.c @@ -54,7 +54,9 @@
assert(func < ARRAY_SIZE(config->peg_cfg));
- const bool slot_implemented = !config->peg_cfg[func].is_onboard; + const struct peg_config *peg_cfg = &config->peg_cfg[func]; + + const bool slot_implemented = !peg_cfg->is_onboard;
if (slot_implemented) { /* Default is 1, but register is R/WO and needs to be written to once */ @@ -69,7 +71,7 @@ /* Physical slot number (zero for ports connected to onboard devices) */ slotcap &= ~(0x1fff << 19); if (slot_implemented) { - uint16_t slot_number = config->peg_cfg[func].phys_slot_number & 0x1fff; + uint16_t slot_number = peg_cfg->phys_slot_number & 0x1fff; if (slot_number == 0) { /* Slot number must be non-zero and unique */ slot_number = func + 1; @@ -79,9 +81,9 @@
/* Default to 1.0 watt scale */ slotcap &= ~(3 << 15); - slotcap |= (config->peg_cfg[func].power_limit_scale & 3) << 15; + slotcap |= (peg_cfg->power_limit_scale & 3) << 15;
- uint8_t power_limit_value = config->peg_cfg[func].power_limit_value; + uint8_t power_limit_value = peg_cfg->power_limit_value; if (power_limit_value == 0) { /* Default to 75 watts */ power_limit_value = 75;