Change in coreboot[master]: util/inteltool: powermgt: add code for dumping config registers
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39509 )
Change subject: util/inteltool: powermgt: add code for dumping config registers ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39509/8/util/inteltool/powermgt.c File util/inteltool/powermgt.c:
https://review.coreboot.org/c/coreboot/+/39509/8/util/inteltool/powermgt.c@6... PS8, Line 678: struct pci_dev *acpi;
"= NULL" is missing here. […]
Done
https://review.coreboot.org/c/coreboot/+/39509/8/util/inteltool/powermgt.c@8... PS8, Line 899: if (acpi) : pci_free_dev(acpi);
i'd move this to line 867 after the switch case statement and before the for loop, since the for loop doesn't need the acpi device pointer.
It does, see line 874 for example: "pci_read_long(acpi, ..."
i'd also like to see the pci_free_dev(acpi) cleanup in another patch, because it's and additional thing it does that isn't mentioned in the commit message
It's not additional; this was done before in lines 816 and 858. Since acpi is used in the for-loop, this needed to be moved here
-
Michael Niewöhner (Code Review)