Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46652 )
Change subject: Revert "mb/google/dedede: Add mainboard acpi support for GPIO PM configuration"
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46652/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/46652/2/src/mainboard/google/dedede...
PS2, Line 42: <soc/intel/common/acpi/lpit.asl>
Do we lose any functionality in the kernel by not exposing LPIT? We won't really use any function now that the save/restore is being dropped. But, does the kernel use the table to make any decision about S0ix?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46652
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e3be42cd82fd3ae919d23d6f19c84a90b9c737a
Gerrit-Change-Number: 46652
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 22 Oct 2020 20:48:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment