Attention is currently required from: Felix Singer, Nico Huber, Angel Pons, Elyes Haouas.
Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61540 )
Change subject: mb/asus/p8x7x-series: Refactor mainboard_get_spd() ......................................................................
Patch Set 7:
(2 comments)
Patchset:
PS4:
As far as precedents go, it has already been set. […]
I just uploaded a new patch set that executes option 3. However the way Angel describes things, it may pan out more like option 4 (which isn't all that different).
Elyes, I have to leave the #include in for p8z77-m(_pro) because it indirectly declares another hook for MRC raminit, that we found out the hard way earlier, as these two still supports MRC raminit. That part is being addressed by CB:72496. After we get this in, Please get that in as well, and then I'll put out a patch to completely clean those two up. Thanks.
Patchset:
PS7: Nico, I'm not sure if devicetree covers romstage. Even if it does, it is better done by someone better versed in devicetree.
-
Keith Hui (Code Review)