Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43072 )
Change subject: soc/intel/skylake: Support NHLT 1ch DMIC
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43072/12/src/soc/intel/skylake/nhlt...
File src/soc/intel/skylake/nhlt/dmic.c:
https://review.coreboot.org/c/coreboot/+/43072/12/src/soc/intel/skylake/nhlt...
PS12, Line 27: .device = 0x1, // NHLT_PDM_DEV on cAVS1.5 (KBL) based platforms
Why not apply CB:45010 first, then add support for 1ch DMIC?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43072
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idba3a714faab5ca1958de7dcfc0fc667c60ea7fd
Gerrit-Change-Number: 43072
Gerrit-PatchSet: 12
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 13 Nov 2020 19:09:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment