EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40567 )
Change subject: mb/google/deltaur: Move early gpio table to variants ......................................................................
mb/google/deltaur: Move early gpio table to variants
If set variant early gpio table NULL, it will override the baseboard table. Move early gpio table to variant level.
BUG=b:154310066 TEST=Check H1 has no I2C error occurs.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ie4c4648ccf918446a499019a4f77f64e43a92c76 --- M src/mainboard/google/deltaur/variants/baseboard/gpio.c M src/mainboard/google/deltaur/variants/deltan/gpio.c 2 files changed, 36 insertions(+), 41 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/40567/1
diff --git a/src/mainboard/google/deltaur/variants/baseboard/gpio.c b/src/mainboard/google/deltaur/variants/baseboard/gpio.c index 71a07b6..a96e702 100644 --- a/src/mainboard/google/deltaur/variants/baseboard/gpio.c +++ b/src/mainboard/google/deltaur/variants/baseboard/gpio.c @@ -406,44 +406,6 @@ return gpio_table; }
-/* GPIO pads configured in bootblock */ -static const struct pad_config early_gpio_table[] = { - /* A23 : GPP_A23 ==> RECOVERY# */ - PAD_CFG_GPI(GPP_A23, NONE, DEEP), - /* C20 : GPP_C20 ==> PCHRX_SERVOTX_UART */ - PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1), - /* C21 : CPP_G21 ==> PCHTX_SERVORX_UART */ - PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1), - /* C22 : GPP_C22 ==> H1_FLASH_WP */ - PAD_CFG_GPI(GPP_C22, NONE, DEEP), - /* C23 : GPP_C23 ==> H1_PCH_INT# */ - PAD_CFG_GPI_APIC(GPP_C23, NONE, DEEP, LEVEL, INVERT), - /* E3 : GPP_E3 ==> MEM_INTERLEAVED */ - PAD_CFG_GPI(GPP_E3, NONE, PLTRST), - /* F11 : GPP_F11 ==> MEM_CONFIG0_1P8 */ - PAD_CFG_GPI(GPP_F11, NONE, DEEP), - /* F12 : GPP_F12 ==> MEM_CONFIG1_1P8 */ - PAD_CFG_GPI(GPP_F12, NONE, DEEP), - /* F13 : GPP_F13 ==> MEM_CONFIG2_1P8 */ - PAD_CFG_GPI(GPP_F13, NONE, DEEP), - /* F14 : GPP_F14 ==> MEM_CONFIG3_1P8 */ - PAD_CFG_GPI(GPP_F14, NONE, DEEP), - /* F15 : GPP_F15 ==> MEM_CONFIG4_1P8 */ - PAD_CFG_GPI(GPP_F15, NONE, DEEP), - /* F16 : GPP_F16 ==> WWAN_BB_RST#_1P8 */ - PAD_CFG_GPO(GPP_F16, 0, DEEP), - /* H4 : GPP_H4 ==> DDR_CHA_EN_1P8 */ - PAD_CFG_GPI(GPP_H4, NONE, DEEP), - /* H5 : GPP_H5 ==> DDR_CHB_EN_1P8 */ - PAD_CFG_GPI(GPP_H5, NONE, DEEP), - /* H6 : GPP_H6 ==> I2C_SDA_PCH_H1 */ - PAD_CFG_NF(GPP_H6, NONE, DEEP, NF1), - /* H7 : GPP_H7 ==> I2C_SCL_PCH_H1 */ - PAD_CFG_NF(GPP_H7, NONE, DEEP, NF1), - /* GPD3: GPD3 ==> SIO_PWRBTN# */ - PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), -}; - static const struct cros_gpio cros_gpios[] = { CROS_GPIO_REC_AL(GPIO_REC_MODE, CROS_GPIO_NAME), CROS_GPIO_WP_AH(GPIO_PCH_WP, CROS_GPIO_NAME), @@ -465,8 +427,8 @@ /* Weak implementation of early gpio */ const struct pad_config *__weak variant_early_gpio_table(size_t *num) { - *num = ARRAY_SIZE(early_gpio_table); - return early_gpio_table; + *num = 0; + return NULL; }
int __weak has_360_sensor_board(void) diff --git a/src/mainboard/google/deltaur/variants/deltan/gpio.c b/src/mainboard/google/deltaur/variants/deltan/gpio.c index 30315bb..f67302f 100644 --- a/src/mainboard/google/deltaur/variants/deltan/gpio.c +++ b/src/mainboard/google/deltaur/variants/deltan/gpio.c @@ -21,7 +21,40 @@
/* Early pad configuration in bootblock */ static const struct pad_config early_gpio_table[] = { - + /* A23 : GPP_A23 ==> RECOVERY# */ + PAD_CFG_GPI(GPP_A23, NONE, DEEP), + /* C20 : GPP_C20 ==> PCHRX_SERVOTX_UART */ + PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1), + /* C21 : CPP_G21 ==> PCHTX_SERVORX_UART */ + PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1), + /* C22 : GPP_C22 ==> H1_FLASH_WP */ + PAD_CFG_GPI(GPP_C22, NONE, DEEP), + /* C23 : GPP_C23 ==> H1_PCH_INT# */ + PAD_CFG_GPI_APIC(GPP_C23, NONE, DEEP, LEVEL, INVERT), + /* E3 : GPP_E3 ==> MEM_INTERLEAVED */ + PAD_CFG_GPI(GPP_E3, NONE, PLTRST), + /* F11 : GPP_F11 ==> MEM_CONFIG0_1P8 */ + PAD_CFG_GPI(GPP_F11, NONE, DEEP), + /* F12 : GPP_F12 ==> MEM_CONFIG1_1P8 */ + PAD_CFG_GPI(GPP_F12, NONE, DEEP), + /* F13 : GPP_F13 ==> MEM_CONFIG2_1P8 */ + PAD_CFG_GPI(GPP_F13, NONE, DEEP), + /* F14 : GPP_F14 ==> MEM_CONFIG3_1P8 */ + PAD_CFG_GPI(GPP_F14, NONE, DEEP), + /* F15 : GPP_F15 ==> MEM_CONFIG4_1P8 */ + PAD_CFG_GPI(GPP_F15, NONE, DEEP), + /* F16 : GPP_F16 ==> WWAN_BB_RST#_1P8 */ + PAD_CFG_GPO(GPP_F16, 0, DEEP), + /* H4 : GPP_H4 ==> DDR_CHA_EN_1P8 */ + PAD_CFG_GPI(GPP_H4, NONE, DEEP), + /* H5 : GPP_H5 ==> DDR_CHB_EN_1P8 */ + PAD_CFG_GPI(GPP_H5, NONE, DEEP), + /* H6 : GPP_H6 ==> I2C_SDA_PCH_H1 */ + PAD_CFG_NF(GPP_H6, NONE, DEEP, NF1), + /* H7 : GPP_H7 ==> I2C_SCL_PCH_H1 */ + PAD_CFG_NF(GPP_H7, NONE, DEEP, NF1), + /* GPD3: GPD3 ==> SIO_PWRBTN# */ + PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), };
const struct pad_config *variant_early_gpio_table(size_t *num)
Hello Furquan Shaikh, Tim Wawrzynczak, Bora Guvendik, Selma Bensaid,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40567
to look at the new patch set (#2).
Change subject: mb/google/deltaur: Move early gpio table to variants ......................................................................
mb/google/deltaur: Move early gpio table to variants
If set variant early gpio table NULL, it will override the baseboard table. Move early gpio table to variant level.
BUG=b:154310066 TEST=Check H1 has no I2C error occurs.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ie4c4648ccf918446a499019a4f77f64e43a92c76 --- M src/mainboard/google/deltaur/variants/baseboard/gpio.c M src/mainboard/google/deltaur/variants/deltan/gpio.c 2 files changed, 36 insertions(+), 41 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/40567/2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40567 )
Change subject: mb/google/deltaur: Move early gpio table to variants ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40567/2/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/40567/2/src/mainboard/google/deltau... PS2, Line 427: /* Weak implementation of early gpio */ : const struct pad_config *__weak variant_early_gpio_table(size_t *num) : { : *num = 0; : return NULL; : } How about we just remove this from baseboard, and then move it to variants/deltaur as well? Then we don't need weak symbols at all for this.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40567 )
Change subject: mb/google/deltaur: Move early gpio table to variants ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40567/2/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/40567/2/src/mainboard/google/deltau... PS2, Line 427: /* Weak implementation of early gpio */ : const struct pad_config *__weak variant_early_gpio_table(size_t *num) : { : *num = 0; : return NULL; : }
How about we just remove this from baseboard, and then move it to variants/deltaur as well? Then we […]
LGTM, will do tomorrow.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Bora Guvendik, Selma Bensaid,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40567
to look at the new patch set (#3).
Change subject: mb/google/deltaur: Move early gpio table to variants ......................................................................
mb/google/deltaur: Move early gpio table to variants
If set variant early gpio table NULL, it will override the baseboard table. Move early gpio table to variant level.
BUG=b:154310066 TEST=Check H1 has no I2C error occurs.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ie4c4648ccf918446a499019a4f77f64e43a92c76 --- M src/mainboard/google/deltaur/variants/baseboard/gpio.c M src/mainboard/google/deltaur/variants/deltan/gpio.c M src/mainboard/google/deltaur/variants/deltaur/gpio.c 3 files changed, 68 insertions(+), 47 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/40567/3
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40567 )
Change subject: mb/google/deltaur: Move early gpio table to variants ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40567/2/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/40567/2/src/mainboard/google/deltau... PS2, Line 427: /* Weak implementation of early gpio */ : const struct pad_config *__weak variant_early_gpio_table(size_t *num) : { : *num = 0; : return NULL; : }
LGTM, will do tomorrow.
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40567 )
Change subject: mb/google/deltaur: Move early gpio table to variants ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40567/3/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/40567/3/src/mainboard/google/deltau... PS3, Line 410: early_gpio_table Is the table used in deltaur and deltan exactly the same? If yes, then you don't need to drop this from the baseboard/gpio.c. Just remove the variant_early_gpio_table() implementation in deltaur and deltan.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40567 )
Change subject: mb/google/deltaur: Move early gpio table to variants ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40567/3/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/40567/3/src/mainboard/google/deltau... PS3, Line 410: early_gpio_table
Is the table used in deltaur and deltan exactly the same? If yes, then you don't need to drop this f […]
We don't have any HW design for deltaur right now. But it suppose will have slightly different.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40567 )
Change subject: mb/google/deltaur: Move early gpio table to variants ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40567/3/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/40567/3/src/mainboard/google/deltau... PS3, Line 410: early_gpio_table
We don't have any HW design for deltaur right now. But it suppose will have slightly different.
If it is unknown at this point, I would recommend just using this weak table in baseboard for now and once you have more details on deltaur you can re-evaluate this.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40567 )
Change subject: mb/google/deltaur: Move early gpio table to variants ......................................................................
Patch Set 3:
I am okay with both. @Tim, what do you think?
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40567 )
Change subject: mb/google/deltaur: Move early gpio table to variants ......................................................................
Patch Set 3:
Patch Set 3:
I am okay with both. @Tim, what do you think?
Well, we're only going to have the two variants (or 3 with the deltaur-360). I guess let's just leave it as is for now, and then when we have deltaur schematics/design, we can eliminate the weak symbol.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40567 )
Change subject: mb/google/deltaur: Move early gpio table to variants ......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 3:
I am okay with both. @Tim, what do you think?
Well, we're only going to have the two variants (or 3 with the deltaur-360). I guess let's just leave it as is for now, and then when we have deltaur schematics/design, we can eliminate the weak symbol.
Also the build failure is jenkins or something, so try to rebase later to get it to try and rebuild it.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40567 )
Change subject: mb/google/deltaur: Move early gpio table to variants ......................................................................
Patch Set 4:
Oh,no I need to rollback to Patch 2.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Bora Guvendik, Selma Bensaid,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40567
to look at the new patch set (#5).
Change subject: mb/google/deltaur: Move early gpio table to variants ......................................................................
mb/google/deltaur: Move early gpio table to variants
If set variant early gpio table NULL, it will override the baseboard table. Move early gpio table to variant level.
BUG=b:154310066 TEST=Check H1 has no I2C error occurs.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ie4c4648ccf918446a499019a4f77f64e43a92c76 --- M src/mainboard/google/deltaur/variants/baseboard/gpio.c M src/mainboard/google/deltaur/variants/deltan/gpio.c 2 files changed, 36 insertions(+), 41 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/40567/5
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40567 )
Change subject: mb/google/deltaur: Move early gpio table to variants ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40567/3/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/40567/3/src/mainboard/google/deltau... PS3, Line 410: early_gpio_table
If it is unknown at this point, I would recommend just using this weak table in baseboard for now an […]
Done
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40567 )
Change subject: mb/google/deltaur: Move early gpio table to variants ......................................................................
Patch Set 5: Code-Review+2
sorry thanks eric!
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40567 )
Change subject: mb/google/deltaur: Move early gpio table to variants ......................................................................
mb/google/deltaur: Move early gpio table to variants
If set variant early gpio table NULL, it will override the baseboard table. Move early gpio table to variant level.
BUG=b:154310066 TEST=Check H1 has no I2C error occurs.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ie4c4648ccf918446a499019a4f77f64e43a92c76 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40567 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/deltaur/variants/baseboard/gpio.c M src/mainboard/google/deltaur/variants/deltan/gpio.c 2 files changed, 36 insertions(+), 41 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/deltaur/variants/baseboard/gpio.c b/src/mainboard/google/deltaur/variants/baseboard/gpio.c index 71a07b6..a96e702 100644 --- a/src/mainboard/google/deltaur/variants/baseboard/gpio.c +++ b/src/mainboard/google/deltaur/variants/baseboard/gpio.c @@ -406,44 +406,6 @@ return gpio_table; }
-/* GPIO pads configured in bootblock */ -static const struct pad_config early_gpio_table[] = { - /* A23 : GPP_A23 ==> RECOVERY# */ - PAD_CFG_GPI(GPP_A23, NONE, DEEP), - /* C20 : GPP_C20 ==> PCHRX_SERVOTX_UART */ - PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1), - /* C21 : CPP_G21 ==> PCHTX_SERVORX_UART */ - PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1), - /* C22 : GPP_C22 ==> H1_FLASH_WP */ - PAD_CFG_GPI(GPP_C22, NONE, DEEP), - /* C23 : GPP_C23 ==> H1_PCH_INT# */ - PAD_CFG_GPI_APIC(GPP_C23, NONE, DEEP, LEVEL, INVERT), - /* E3 : GPP_E3 ==> MEM_INTERLEAVED */ - PAD_CFG_GPI(GPP_E3, NONE, PLTRST), - /* F11 : GPP_F11 ==> MEM_CONFIG0_1P8 */ - PAD_CFG_GPI(GPP_F11, NONE, DEEP), - /* F12 : GPP_F12 ==> MEM_CONFIG1_1P8 */ - PAD_CFG_GPI(GPP_F12, NONE, DEEP), - /* F13 : GPP_F13 ==> MEM_CONFIG2_1P8 */ - PAD_CFG_GPI(GPP_F13, NONE, DEEP), - /* F14 : GPP_F14 ==> MEM_CONFIG3_1P8 */ - PAD_CFG_GPI(GPP_F14, NONE, DEEP), - /* F15 : GPP_F15 ==> MEM_CONFIG4_1P8 */ - PAD_CFG_GPI(GPP_F15, NONE, DEEP), - /* F16 : GPP_F16 ==> WWAN_BB_RST#_1P8 */ - PAD_CFG_GPO(GPP_F16, 0, DEEP), - /* H4 : GPP_H4 ==> DDR_CHA_EN_1P8 */ - PAD_CFG_GPI(GPP_H4, NONE, DEEP), - /* H5 : GPP_H5 ==> DDR_CHB_EN_1P8 */ - PAD_CFG_GPI(GPP_H5, NONE, DEEP), - /* H6 : GPP_H6 ==> I2C_SDA_PCH_H1 */ - PAD_CFG_NF(GPP_H6, NONE, DEEP, NF1), - /* H7 : GPP_H7 ==> I2C_SCL_PCH_H1 */ - PAD_CFG_NF(GPP_H7, NONE, DEEP, NF1), - /* GPD3: GPD3 ==> SIO_PWRBTN# */ - PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), -}; - static const struct cros_gpio cros_gpios[] = { CROS_GPIO_REC_AL(GPIO_REC_MODE, CROS_GPIO_NAME), CROS_GPIO_WP_AH(GPIO_PCH_WP, CROS_GPIO_NAME), @@ -465,8 +427,8 @@ /* Weak implementation of early gpio */ const struct pad_config *__weak variant_early_gpio_table(size_t *num) { - *num = ARRAY_SIZE(early_gpio_table); - return early_gpio_table; + *num = 0; + return NULL; }
int __weak has_360_sensor_board(void) diff --git a/src/mainboard/google/deltaur/variants/deltan/gpio.c b/src/mainboard/google/deltaur/variants/deltan/gpio.c index 30315bb..f67302f 100644 --- a/src/mainboard/google/deltaur/variants/deltan/gpio.c +++ b/src/mainboard/google/deltaur/variants/deltan/gpio.c @@ -21,7 +21,40 @@
/* Early pad configuration in bootblock */ static const struct pad_config early_gpio_table[] = { - + /* A23 : GPP_A23 ==> RECOVERY# */ + PAD_CFG_GPI(GPP_A23, NONE, DEEP), + /* C20 : GPP_C20 ==> PCHRX_SERVOTX_UART */ + PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1), + /* C21 : CPP_G21 ==> PCHTX_SERVORX_UART */ + PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1), + /* C22 : GPP_C22 ==> H1_FLASH_WP */ + PAD_CFG_GPI(GPP_C22, NONE, DEEP), + /* C23 : GPP_C23 ==> H1_PCH_INT# */ + PAD_CFG_GPI_APIC(GPP_C23, NONE, DEEP, LEVEL, INVERT), + /* E3 : GPP_E3 ==> MEM_INTERLEAVED */ + PAD_CFG_GPI(GPP_E3, NONE, PLTRST), + /* F11 : GPP_F11 ==> MEM_CONFIG0_1P8 */ + PAD_CFG_GPI(GPP_F11, NONE, DEEP), + /* F12 : GPP_F12 ==> MEM_CONFIG1_1P8 */ + PAD_CFG_GPI(GPP_F12, NONE, DEEP), + /* F13 : GPP_F13 ==> MEM_CONFIG2_1P8 */ + PAD_CFG_GPI(GPP_F13, NONE, DEEP), + /* F14 : GPP_F14 ==> MEM_CONFIG3_1P8 */ + PAD_CFG_GPI(GPP_F14, NONE, DEEP), + /* F15 : GPP_F15 ==> MEM_CONFIG4_1P8 */ + PAD_CFG_GPI(GPP_F15, NONE, DEEP), + /* F16 : GPP_F16 ==> WWAN_BB_RST#_1P8 */ + PAD_CFG_GPO(GPP_F16, 0, DEEP), + /* H4 : GPP_H4 ==> DDR_CHA_EN_1P8 */ + PAD_CFG_GPI(GPP_H4, NONE, DEEP), + /* H5 : GPP_H5 ==> DDR_CHB_EN_1P8 */ + PAD_CFG_GPI(GPP_H5, NONE, DEEP), + /* H6 : GPP_H6 ==> I2C_SDA_PCH_H1 */ + PAD_CFG_NF(GPP_H6, NONE, DEEP, NF1), + /* H7 : GPP_H7 ==> I2C_SCL_PCH_H1 */ + PAD_CFG_NF(GPP_H7, NONE, DEEP, NF1), + /* GPD3: GPD3 ==> SIO_PWRBTN# */ + PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), };
const struct pad_config *variant_early_gpio_table(size_t *num)
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40567 )
Change subject: mb/google/deltaur: Move early gpio table to variants ......................................................................
Patch Set 6:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2667 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2666 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2665 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/2664
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
EricR Lai (Code Review)
-
Furquan Shaikh (Code Review)
-
Tim Wawrzynczak (Code Review)