[S] Change in coreboot[master]: mb/brya/variant/bb/{brya,hades}/include/ec: Add EC_HOST_EVENT_GPU
Attention is currently required from: Daisuke Nojiri, Tarun Tuli, Nick Vaccaro.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73217 )
Change subject: mb/brya/variant/bb/{brya,hades}/include/ec: Add EC_HOST_EVENT_GPU ......................................................................
Patch Set 8:
(2 comments)
File src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h:
PS8: i think `baseboard/skolas/include/baseboard/ec.h` needs the same treatment.
can we just symlink the two files?
https://review.coreboot.org/c/coreboot/+/73217/comment/9a6405a5_0bcb7192 PS8, Line 19: EC_HOST_EVENT_GPU
What is the thinking of excluding this mask on some variants? Would we potentially reuse the same b […]
no, i had a look at some of the other baseboards and the pattern is to enable what you actually use. we already have a config for dGPU so it seems to make sense to apply it where appropriate. i'm not sure if `INCLUDE_NVIDIA_GPU_ASL` really needs to be specific to either of nvidia or ASL.
repurposing event bits is dangerous as we saw on another project (we unintentionally ended up with a wake source).
i'd be OK with enabling all the interesting events uniformly across all the baseboards and then trust the EC to not generate events that don't "exist" on a specific board. i'm not sure that's feasible - i don't know the history of how we ended up with custom event masks per baseboard.
-
Caveh Jalali (Code Review)