Attention is currently required from: Nico Huber, Subrata Banik, Paul Menzel, Arthur Heymans.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64077 )
Change subject: soc/intel/cmn/fast-spi: Add BIOS MMIO window as reserved region
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/fast_spi/fast_spi.c:
https://review.coreboot.org/c/coreboot/+/64077/comment/a2e0a805_67bb5e4b
PS2, Line 528: mmio_resource(dev, 0, FLASH_BASE_ADDR / KiB, CONFIG_ROM_SIZE / KiB);
OK, looking at the APL spec it is really fixed to 16 MB. Will update.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64077
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3a77e9233c3c63bad4de926670edb4545ceaddf
Gerrit-Change-Number: 64077
Gerrit-PatchSet: 3
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 06 May 2022 10:13:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment