Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36169 )
Change subject: drivers/intel/fsp2_0: Hide CONFIG_FSP_CAR ......................................................................
drivers/intel/fsp2_0: Hide CONFIG_FSP_CAR
CONFIG_FSP_CAR should not be a user visible option, but depends on the choice presented in the soc Kconfig.
This also removes the dependencies on ADD_FSP_BINARIES. You need to included those for other stages too so there is no need to make this requirement explicit for FSP-T.
Change-Id: Ida32e9c4f5839aef4d4deb7a1c7fabe6335a5d2a Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/36169 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/drivers/intel/fsp2_0/Kconfig 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/drivers/intel/fsp2_0/Kconfig b/src/drivers/intel/fsp2_0/Kconfig index 765d643..b434a51 100644 --- a/src/drivers/intel/fsp2_0/Kconfig +++ b/src/drivers/intel/fsp2_0/Kconfig @@ -123,8 +123,7 @@ The path and filename of the Intel FSP-S binary for this platform.
config FSP_CAR - bool "Use FSP TempRamInit & TempRamExit APIs" - depends on ADD_FSP_BINARIES + bool default n help Use FSP APIs to initialize & Tear Down the Cache-As-Ram