Attention is currently required from: Ravi kumar, Ravi Kumar Bokka.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49768 )
Change subject: sc7280: Add CPUCP firmware support
......................................................................
Patch Set 85:
(2 comments)
File src/soc/qualcomm/sc7280/include/soc/cpucp.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132078):
https://review.coreboot.org/c/coreboot/+/49768/comment/604c7c24_dc9aa543
PS85, Line 6: #define EPSSTOP_EPSS_TOP (void *)0x18598000
Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132078):
https://review.coreboot.org/c/coreboot/+/49768/comment/af3492be_ed49750e
PS85, Line 7: #define EPSSFAST_BASE_ADDR (void *)0x18580000
Macros with complex values should be enclosed in parentheses
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49768
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idac22c8cb231658616999bc577bdf49f9aa7ae74
Gerrit-Change-Number: 49768
Gerrit-PatchSet: 85
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Wed, 03 Nov 2021 00:19:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment