Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44108 )
Change subject: soc/intel/common: Include Alderlake device IDs
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/44108/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/cpu/mp_init.c:
https://review.coreboot.org/c/coreboot/+/44108/1/src/soc/intel/common/block/...
PS1, Line 79: }
nit: space before }. All entries except JSL seem to follow that pattern.
https://review.coreboot.org/c/coreboot/+/44108/1/src/soc/intel/common/block/...
PS1, Line 80: }
Same here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44108
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17ce56a220e4dce2db2e0e69561b3d6dac9e65a2
Gerrit-Change-Number: 44108
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 03 Aug 2020 21:42:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment