Attention is currently required from: Alexander Couzens, Elyes Haouas, Felix Held, Nicholas Chin, Stefan Ott.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77738?usp=email )
Change subject: sb/intel/i82801{i,j}x/chip.h: Use boolean where appropriate
......................................................................
Patch Set 8: Code-Review+2
(4 comments)
File src/southbridge/intel/i82801ix/chip.h:
https://review.coreboot.org/c/coreboot/+/77738/comment/01679a5e_5d06f5c9 :
PS4, Line 59: unsigned int sata_clock_request : 1;
: u
I need to look into these.
Done
https://review.coreboot.org/c/coreboot/+/77738/comment/7fec1183_d544a84b :
PS4, Line 77: uint8_t pcie_hotplug_map[8];
This should be bool as well.
Done
File src/southbridge/intel/i82801jx/chip.h:
https://review.coreboot.org/c/coreboot/+/77738/comment/7c4a2597_dd175e6b :
PS4, Line 46: unsigned int sata_clock_request : 1;
Sounds like it could be bool. I need to look into it.
Done
https://review.coreboot.org/c/coreboot/+/77738/comment/ec37852b_039ff61c :
PS4, Line 63: uint8_t pcie_hotplug_map[8];
This should be bool as well.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77738?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I867451ae3d6d37033c9e0e57a4d7fd4a06dedbef
Gerrit-Change-Number: 77738
Gerrit-PatchSet: 8
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Stefan Ott
coreboot@desire.ch
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Stefan Ott
coreboot@desire.ch
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 12 Jan 2024 19:13:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-MessageType: comment