Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48829 )
Change subject: soc/intel/*: drop UART pad configuration from common code
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48829/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48829/6//COMMIT_MSG@9
PS6, Line 9: UART pad configuration should not be done in common code, because that
: may cause short circuits, when the user sets a wrong UART index.
FIXED_UART_FOR_CONSOLE was just a workaround but does not fix the underlying issue.
I was unaware of that, but what is the underlying issue? There won't be any GPIO misconfiguration if the UART number is set correctly.
Nothing wrong per se. It's just inconistent and thereby more error-prone.
Before we introduced FIXED_UART_FOR_CONSOLE, the defaults were almost
always wrong btw.
One more addition on this: people still don't get this right; see at least ehl rvp... there were some more that set `0` while they mean `disable`, but `0` is UART0 - but the pads are connected elsewhere
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48829
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id03719eb8bd0414083148471ed05dea62a895126
Gerrit-Change-Number: 48829
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 23 Dec 2020 20:29:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment