Attention is currently required from: Angel Pons, Arthur Heymans, Felix Held, Krystian Hebel, Michał Żygowski, Nico Huber.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77338?usp=email )
Change subject: device/pciexp_device.c: Fix setting Max Payload Size
......................................................................
Patch Set 10:
(1 comment)
File src/device/pciexp_device.c:
https://review.coreboot.org/c/coreboot/+/77338/comment/d7cdb98c_33399de0 :
PS10, Line 709: pciexp_configure_max_payload
instead of adding all of the new code, wouldn't it be simpler to do something like this here:
```
/* Walk up the chain and adjust MaxPayload to the minimum supported in the chain */
while (dev->bus && dev->bus->dev && !pciexp_device_is_root_port(dev)) {
...
/* Adjust Max_Payload_Size */
pciexp_set_max_payload_size(dev->bus->dev, root_cap, dev, cap);
dev = dev->bus->dev;
};
```
That way all of the devices are updated with the minimum supported MaxPayload and every time a new downstream device is added it traverses the chain up again to potentially set a newer and lower limit.
It increases the runtime exponentially, but as it's a corner case anyway it should have no influence on 99.9% of regular systems.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77338?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I24386dc208363b7d94fea46dec25c231a3968225
Gerrit-Change-Number: 77338
Gerrit-PatchSet: 10
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 12 Oct 2023 06:35:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment