Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36444 )
Change subject: device/Kconfig: hide display menu when NO_GFX_INIT is selected
......................................................................
Patch Set 2:
Hmmm, it doesn't have the anticipated effect :-/ I would have
expected a Verified -1, because aspeed/ isn't fixed yet. But
the error is only triggered with NO_GFX_INIT in the config and
that's not the default... I guess there is nothing we can do?
I guess no (without adding some "CONFIG_JENKINS_TEST" or whatever) :S
Hah, we already have that in a way. I just keep forgetting about it. Just
add a config file to configs/... e.g. configs/no-gfx-init
CONFIG_VENDOR_LENOVO=y
CONFIG_NO_GFX_INIT=y
should do the trick, I guess.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36444
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec5a47f84b8c776a45edc6f4b31a03b9ac714b4e
Gerrit-Change-Number: 36444
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 Nov 2019 09:51:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment