Change in coreboot[master]: mb/pcengines/apu1: Remove PS/2 keyboard driver configuration
Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40751 )
Change subject: mb/pcengines/apu1: Remove PS/2 keyboard driver configuration ......................................................................
mb/pcengines/apu1: Remove PS/2 keyboard driver configuration
Since commit 6aa8c5bc (drivers/pc80: Do not initialize PS2 keyboard by default), the Kconfig option `DRIVERS_PS2_KEYBOARD` already defaults to `n`. So, remove it here, as this option should be user selectable anyway depending on the payload.
Change-Id: I3d08fb6bbb3e9d53fd2fed96f26679e8b1e73f8c Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/mainboard/pcengines/apu1/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/40751/1
diff --git a/src/mainboard/pcengines/apu1/Kconfig b/src/mainboard/pcengines/apu1/Kconfig index d25825e..bf58575 100644 --- a/src/mainboard/pcengines/apu1/Kconfig +++ b/src/mainboard/pcengines/apu1/Kconfig @@ -72,10 +72,6 @@ bool default n
-config DRIVERS_PS2_KEYBOARD - bool - default n - choice prompt "J19 pins 1-10" default APU1_PINMUX_OFF_C
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40751 )
Change subject: mb/pcengines/apu1: Remove PS/2 keyboard driver configuration ......................................................................
Patch Set 1: Code-Review+2
Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40751 )
Change subject: mb/pcengines/apu1: Remove PS/2 keyboard driver configuration ......................................................................
mb/pcengines/apu1: Remove PS/2 keyboard driver configuration
Since commit 6aa8c5bc (drivers/pc80: Do not initialize PS2 keyboard by default), the Kconfig option `DRIVERS_PS2_KEYBOARD` already defaults to `n`. So, remove it here, as this option should be user selectable anyway depending on the payload.
Change-Id: I3d08fb6bbb3e9d53fd2fed96f26679e8b1e73f8c Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/40751 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michał Żygowski michal.zygowski@3mdeb.com --- M src/mainboard/pcengines/apu1/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Michał Żygowski: Looks good to me, approved
diff --git a/src/mainboard/pcengines/apu1/Kconfig b/src/mainboard/pcengines/apu1/Kconfig index d25825e..bf58575 100644 --- a/src/mainboard/pcengines/apu1/Kconfig +++ b/src/mainboard/pcengines/apu1/Kconfig @@ -72,10 +72,6 @@ bool default n
-config DRIVERS_PS2_KEYBOARD - bool - default n - choice prompt "J19 pins 1-10" default APU1_PINMUX_OFF_C
-
Matt DeVillier (Code Review) -
Michał Żygowski (Code Review)
-
Paul Menzel (Code Review)