Change in ...coreboot[master]: [WIP]arch/x86/postcar: Add x86_64 support - coreboot-gerrit

6 Mar 2019


      Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30500 )
Change subject: [WIP]arch/x86/postcar: Add x86_64 support
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/30500/4/src/arch/x86/exit_car.S 
File src/arch/x86/exit_car.S:
https://review.coreboot.org/#/c/30500/4/src/arch/x86/exit_car.S@62 
PS4, Line 62: 	mov	%eax, %cr0
IA manual also says MOV r64, CR0-CR7 here.
This %eax fails with GAS 2.32 (yesterdays toolchain).
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30500
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c190627f5f0ed6f82738cb99423892382899d7b
Gerrit-Change-Number: 30500
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 Mar 2019 05:11:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment