3 Jan
2020
3 Jan
'20
6:05 p.m.
Sathyanarayana Nujella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37882 )
Change subject: src/drivers/i2c: add i2c driver for Realtek 1308 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37882/2/src/drivers/i2c/rt1308/rt13... File src/drivers/i2c/rt1308/rt1308.c:
https://review.coreboot.org/c/coreboot/+/37882/2/src/drivers/i2c/rt1308/rt13... PS2, Line 104: Codec
Is *amplifier* and *codec* the same?
Generally amp is used for speakers and Codec is used for headset Codec's. So, here: using amp is good.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37882
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie44fc8199f2153e18537023dfd92e0ce6a3ecb9c
Gerrit-Change-Number: 37882
Gerrit-PatchSet: 2
Gerrit-Owner: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Jairaj Arava jairaj.arava@intel.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Sathyanarayana Nujella sathyanarayana.nujella@intel.com
Gerrit-Reviewer: Shaunak Saha shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Srinidhi N Kaushik srinidhi.n.kaushik@intel.corp-partner.google.com
Gerrit-Comment-Date: Fri, 03 Jan 2020 18:05:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-MessageType: comment
1823
days inactive
1823
days old
0 comments
1 participants
participants (1)
-
Sathyanarayana Nujella (Code Review)