Attention is currently required from: Ivy Jian. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52181 )
Change subject: mb/google/guybrush/var/guybrush: Add FPMCU configration ......................................................................
Patch Set 17: Code-Review+2
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52181/comment/e8133579_75a856a4 PS17, Line 17: Signed-off-by: Ivy Jian ivy_jian@compal.corp-partner.google.com Duplicate Signed-off-by line.
File src/mainboard/google/guybrush/bootblock.c:
https://review.coreboot.org/c/coreboot/+/52181/comment/6bf712cc_828fbd81 PS17, Line 52: acpi_get_sleep_type() nit: This call can be made at the called site as well i.e. variant_fpmcu_reset() can call this instead of having to pass it as a parameter.
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/52181/comment/92b41455_b6dcc168 PS17, Line 7: #include <gpio.h> I don't think this is required anymore.
https://review.coreboot.org/c/coreboot/+/52181/comment/f36c1099_84458df4 PS17, Line 9: #include <soc/smi.h> Why is this required?