Attention is currently required from: Ravi kumar, Martin Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52371 )
Change subject: sc7280: Add GSI FW download support ......................................................................
Patch Set 7:
(11 comments)
File src/soc/qualcomm/sc7280/include/soc/qupv3_config.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119029): https://review.coreboot.org/c/coreboot/+/52371/comment/1aa97b0f_6edb4bf6 PS7, Line 77: { open brace '{' following struct go on the same line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119029): https://review.coreboot.org/c/coreboot/+/52371/comment/fce4d50d_3e818d57 PS7, Line 79: uint32_t iram_dword1; /* word 1 of a single IRAM firmware entry */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119029): https://review.coreboot.org/c/coreboot/+/52371/comment/5d98e2cf_6c548e75 PS7, Line 83: { open brace '{' following struct go on the same line
File src/soc/qualcomm/sc7280/qupv3_config.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119029): https://review.coreboot.org/c/coreboot/+/52371/comment/a5c16ee5_351fe030 PS7, Line 204: write32(®s->gsi_periph_base_lsb,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119029): https://review.coreboot.org/c/coreboot/+/52371/comment/42749e88_991e7424 PS7, Line 205: write32(®s->gsi_periph_base_msb,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119029): https://review.coreboot.org/c/coreboot/+/52371/comment/4884980b_0a37f4df PS7, Line 210: if (fwIep[i].offset < GSI_REG_BASE_SIZE) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119029): https://review.coreboot.org/c/coreboot/+/52371/comment/0b65ddc3_87b5e72e PS7, Line 221: memcpy((®s->gsi_inst_ramn),(void *)fwIRam, space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119029): https://review.coreboot.org/c/coreboot/+/52371/comment/7b6d65f6_f17ae42a PS7, Line 223: setbits_le32(®s->gsi_mcs_cfg, GSI_MCS_CFG_MCS_ENABLE_BMSK ); space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119029): https://review.coreboot.org/c/coreboot/+/52371/comment/fb316384_dace6959 PS7, Line 224: setbits_le32(®s->gsi_cfg, GSI_CFG_DOUBLE_MCS_CLK_FREQ_BMSK | GSI_CFG_GSI_ENABLE_BMSK); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119029): https://review.coreboot.org/c/coreboot/+/52371/comment/9c9d5dec_95a2de2b PS7, Line 226: write32(®s->gsi_ee_n_scratch_0_addr,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119029): https://review.coreboot.org/c/coreboot/+/52371/comment/fcfb8798_f2da9660 PS7, Line 227: write32(®s->ee_n_gsi_ee_generic_cmd,0x81); space required after that ',' (ctx:VxV)