Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35027 )
Change subject: src/soc/intel: Add ACPI HPET table
......................................................................
Patch Set 2:
(2 comments)
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35027/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35027/1//COMMIT_MSG@10
PS1, Line 10:
please add this was tested, i. […]
Done
https://review.coreboot.org/c/coreboot/+/35027/1/src/mainboard/ocp/monolake/...
File src/mainboard/ocp/monolake/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35027/1/src/mainboard/ocp/monolake/...
PS1, Line 85: /* Enable access to the BMC IPMI via KCS */
There's acpi_write_hpet() which seems to do the same as the code in acpi_create_intel_hpet(), please […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35027
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idae9a7d3d4233037214d6203996bf44fe5f3a845
Gerrit-Change-Number: 35027
Gerrit-PatchSet: 2
Gerrit-Owner: Johnny Lin
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: David Hendricks
dhendrix.sync@gmail.com
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Name of user not set #1002539
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Łukasz Siudut
Gerrit-CC: Andrey Petrov
anpetrov@fb.com
Gerrit-Comment-Date: Mon, 26 Aug 2019 03:23:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Andrey Petrov
anpetrov@fb.com
Gerrit-MessageType: comment