Attention is currently required from: Bora Guvendik, Anil Kumar K, Cliff Huang, Selma Bensaid, Bernardo Perez Priego.
Thejaswani Putta has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54023 )
Change subject: mb/intel/adlrvp_m: Enable CR50 TPM support over SPI
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54023/comment/7d1be95a_3cc31977
PS1, Line 14: Coreboot
coreboot logs.
Done!
Patchset:
PS1:
commit message. […]
Done!
File src/mainboard/intel/adlrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/54023/comment/2553b8f5_bc682ed1
PS1, Line 22: select MAINBOARD_HAS_TPM2
: select MAINBOARD_HAS_SPI_TPM_CR50
: select SPI_TPM
:
Are we enabling for ADLRVP_P also? or ADLRVP_M only?
We are enabling only for ADLRVP_M. I have updated the required configs in the Kconfig with the condition.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54023
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icaedf9f17e35e82c35cbabd6d2938c167e42e9e8
Gerrit-Change-Number: 54023
Gerrit-PatchSet: 4
Gerrit-Owner: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Comment-Date: Mon, 10 May 2021 22:48:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bora Guvendik
bora.guvendik@intel.com
Comment-In-Reply-To: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-MessageType: comment