Change in coreboot[master]: [TESTME] mb/bostentech/gbyt4: Add libgfxinit support

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44938 )

Change subject: [TESTME] mb/bostentech/gbyt4: Add libgfxinit support
......................................................................

[TESTME] mb/bostentech/gbyt4: Add libgfxinit support

Change-Id: Id729f730f93f5c26b603a5b7a94f671f7fd9bfb7
Signed-off-by: Angel Pons 
---
M src/mainboard/bostentech/gbyt4/Kconfig
M src/mainboard/bostentech/gbyt4/Makefile.inc
A src/mainboard/bostentech/gbyt4/gma-mainboard.ads
3 files changed, 18 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/44938/1

diff --git a/src/mainboard/bostentech/gbyt4/Kconfig b/src/mainboard/bostentech/gbyt4/Kconfig
index a267840..d5e8bda 100644
--- a/src/mainboard/bostentech/gbyt4/Kconfig
+++ b/src/mainboard/bostentech/gbyt4/Kconfig
@@ -7,6 +7,7 @@
    select HAVE_ACPI_TABLES
    select HAVE_OPTION_TABLE
    select HAVE_ACPI_RESUME
+	select MAINBOARD_HAS_LIBGFXINIT
    select SUPERIO_ITE_IT8728F

config MAINBOARD_DIR
diff --git a/src/mainboard/bostentech/gbyt4/Makefile.inc b/src/mainboard/bostentech/gbyt4/Makefile.inc
index 11a2a4a..a4fecae 100644
--- a/src/mainboard/bostentech/gbyt4/Makefile.inc
+++ b/src/mainboard/bostentech/gbyt4/Makefile.inc
@@ -3,3 +3,5 @@
 ramstage-y += irqroute.c gpio.c
 bootblock-y += early_init.c
 romstage-y += early_init.c
+
+ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads
diff --git a/src/mainboard/bostentech/gbyt4/gma-mainboard.ads b/src/mainboard/bostentech/gbyt4/gma-mainboard.ads
new file mode 100644
index 0000000..c6422a5
--- /dev/null
+++ b/src/mainboard/bostentech/gbyt4/gma-mainboard.ads
@@ -0,0 +1,15 @@
+-- SPDX-License-Identifier: GPL-2.0-or-later
+
+with HW.GFX.GMA;
+with HW.GFX.GMA.Display_Probing;
+
+use HW.GFX.GMA;
+use HW.GFX.GMA.Display_Probing;
+
+private package GMA.Mainboard is
+
+   ports : constant Port_List :=
+     (Analog,
+      others => Disabled);
+
+end GMA.Mainboard;

[Máté Kukri (Code Review)]

Máté Kukri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44938 )

Change subject: [TESTME] mb/bostentech/gbyt4: Add libgfxinit support
......................................................................

Patch Set 3: Code-Review+1

VGA output works in both text mode and graphics mode. Tested with SeaBIOS and GRUB2.

Change in coreboot[master]: mb/bostentech/gbyt4: Add libgfxinit support

[Angel Pons (Code Review)]

Hello build bot (Jenkins), Máté Kukri, Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44938

to look at the new patch set (#4).

Change subject: mb/bostentech/gbyt4: Add libgfxinit support
......................................................................

mb/bostentech/gbyt4: Add libgfxinit support

Tested with SeaBIOS and GRUB2, VGA output works in both text mode and
linear "high-resolution" framebuffer mode.

Change-Id: Id729f730f93f5c26b603a5b7a94f671f7fd9bfb7
Signed-off-by: Angel Pons 
Tested-by: Mate Kukri 
---
M src/mainboard/bostentech/gbyt4/Kconfig
M src/mainboard/bostentech/gbyt4/Makefile.inc
A src/mainboard/bostentech/gbyt4/gma-mainboard.ads
3 files changed, 18 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/44938/4

Change in coreboot[master]: mb/bostentech/gbyt4: Add libgfxinit support

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44938 )

Change subject: mb/bostentech/gbyt4: Add libgfxinit support
......................................................................

Patch Set 4:
> Patch Set 3: Code-Review+1
>
> VGA output works in both text mode and graphics mode. Tested with SeaBIOS and GRUB2.

Thank you for testing!

[S] Change in coreboot[master]: mb/bostentech/gbyt4: Add libgfxinit support

[Martin L Roth (Code Review)]

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44938?usp=email )

Change subject: mb/bostentech/gbyt4: Add libgfxinit support
......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.