Attention is currently required from: Jakub Czapiga, Michał Żygowski, Subrata Banik.
Marek Maślanka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79909?usp=email )
Change subject: soc/intel/common/block: Add support for watchdog ......................................................................
Patch Set 10:
(3 comments)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/79909/comment/e40d5a83_bb68227c : PS9, Line 405: wdat->min_count = 1;
https://www.intel. […]
Right, the minimum value must be 2 as doc says the minimum time must be 1.2sec which give us 1.2/0.6 = 2. Now the value is taken from dedicated function
https://review.coreboot.org/c/coreboot/+/79909/comment/9d397790_ad66edf5 : PS9, Line 406: tco_get_timer_max_value() * tco_get_timer_period() / 1000;
The max_count field per the WDAT spec is: […]
Right, this value must identify max value in count intervals not in seconds as I though
https://review.coreboot.org/c/coreboot/+/79909/comment/77b44d12_e396c93e : PS9, Line 443: entry->mask = 0x02;
Why is set mask different from get mask above?
because it has the same effect as mask<<bit_offset (1<<1). I have now uniformed this with 'get boot status' for consistency.