Change in coreboot[master]: soc/intel/common/block/acpi: Add LPM requirements support to PEPD _DSM
Attention is currently required from: Cliff Huang, Furquan Shaikh, Angel Pons, Michael Niewöhner, Patrick Rudolph, Karthik Ramasubramanian. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56005 )
Change subject: soc/intel/common/block/acpi: Add LPM requirements support to PEPD _DSM ......................................................................
Patch Set 2:
(6 comments)
File src/soc/intel/common/block/acpi/pep.c:
https://review.coreboot.org/c/coreboot/+/56005/comment/029dde02_d5cba26c PS1, Line 120: static void pep_s0ix_enum_functions(void *unused)
In general, I don't see Kconfig SOC_INTEL_COMMON_BLOCK_ACPI_PEP_LPM_REQ been used to make pep. […]
Yes, in the patches later in this patch train, it is selected for TGL (CB:56007) and ADL (CB:56006).
SOC_INTEL_COMMON_BLOCK_ACPI_PEP_LPM_REQ depends on having CONFIG_SOC_INTEL_COMMON_BLOCK_ACPI_PEP selected first (which compiles in pep.c). There shouldn't be any problems here.
https://review.coreboot.org/c/coreboot/+/56005/comment/0d82c6fb_ac514b82 PS1, Line 143: PMC_IPC_SUBCMD_GEN_COMM_READ,
Please see comments in pmc_ipc. […]
Done
https://review.coreboot.org/c/coreboot/+/56005/comment/534516aa_beeddd05 PS1, Line 166: pep_s0ix_collect_lpm_requirements, /* Return LPM requirements */
use #if for lpm req.
If `SOC_INTEL_COMMON_BLOCK_ACPI_PEP_LPM_REQ` if not compiled in, then the _DSM with Arg0 will return `0`, meaning there are no supported functions under this UUID (see lines 122 and 130).
https://review.coreboot.org/c/coreboot/+/56005/comment/9ccc7ff6_db023225 PS1, Line 173: DSM_UUID(PEP_S0IX_UUID, pep_s0ix, ARRAY_SIZE(pep_s0ix), NULL),
use #if for lpm req.
See above comment.
File src/soc/intel/common/block/include/intelblocks/pmc_ipc.h:
https://review.coreboot.org/c/coreboot/+/56005/comment/b447b330_1a7b00b4 PS1, Line 25: #define PMC_IPC_CMD_GENERAL_COMM 0xA0
Please rename to PMC_IPC_CMD_RD_PMC_REG.
Done
https://review.coreboot.org/c/coreboot/+/56005/comment/2a34c7a1_68cd7d44 PS1, Line 26: #define PMC_IPC_SUBCMD_GEN_COMM_READ 0x02
When Read PMC reg (0xa0) command is used, there is no subcmd/cmd ID needed. […]
Verified, thanks.
-
Tim Wawrzynczak (Code Review)