Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/42359 )
Change subject: gma baytrail: Add connectors support ......................................................................
Patch Set 53:
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx... File common/valleyview/hw-gfx-gma-connectors.adb:
https://review.coreboot.org/c/libgfxinit/+/42359/50/common/valleyview/hw-gfx... PS50, Line 98: end Post_On;
I'm still not sure if I should change this. For DVI and HDMI, Wait_Port_Ready works as intended.
It's also what the PRM suggests. And it's definitely something to try if DP isn't working.
Generally, if there is something that might work either way, it's better to do it the way that seems more likely to be the correct one. If you have to change it later because of a corner case that doesn't work, all the testing until then was for naught.
-
Nico Huber (Code Review)