Attention is currently required from: Arthur Heymans, Iru Cai, Nicholas Chin.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79746?usp=email )
Change subject: mainboard: add Dell Latitude E7240
......................................................................
Patch Set 3:
(5 comments)
File src/mainboard/dell/e7240/Kconfig:
PS3:
Add SPDX license header
File src/mainboard/dell/e7240/Kconfig.name:
PS3:
Add SPDX license header
File src/mainboard/dell/e7240/Makefile.inc:
PS3:
Makefiles use the type .mk now. Please rename.
File src/mainboard/dell/e7240/devicetree.cb:
PS3:
Add SPDX license header
File src/mainboard/dell/e7240/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/79746/comment/36a83a37_7174e3e1 :
PS3, Line 18: /* global NVS and variables. */
Seens superfluous, remove.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79746?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6933bdbcc8d0bbb85d62657624740266284ac71c
Gerrit-Change-Number: 79746
Gerrit-PatchSet: 3
Gerrit-Owner: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Iru Cai
mytbk920423@gmail.com
Gerrit-Comment-Date: Thu, 02 May 2024 21:26:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment