Attention is currently required from: Furquan Shaikh, Subrata Banik, Angel Pons, Kyösti Mälkki, Swift Geek (Sebastian Grzywna).
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57306 )
Change subject: arch/x86: Check unsupported CPU type while writing to SMBIOS table 7
......................................................................
Patch Set 2:
(1 comment)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/57306/comment/656d60bb_56410173
PS2, Line 770: printk(BIOS_DEBUG, "SMBIOS: Unknown CPU\n");
Should the message be more specific?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57306
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id65dc963e235f7080370a32cf69bcc4bee94d28f
Gerrit-Change-Number: 57306
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Swift Geek (Sebastian Grzywna)
swiftgeek@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Swift Geek (Sebastian Grzywna)
swiftgeek@gmail.com
Gerrit-Comment-Date: Wed, 01 Sep 2021 22:57:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment