Change in ...coreboot[master]: cpu/intel: Remove socket_BGA1284

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Nico Huber (Code Review)

27 Feb 2019 27 Feb '19

11:07 p.m.

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31646

Change subject: cpu/intel: Remove socket_BGA1284 ......................................................................

cpu/intel: Remove socket_BGA1284

Unused since the removal of `fsp_sandybridge`.

Change-Id: Iea31e341c3df680ed48db4f8734d9d0bde120be3 Signed-off-by: Nico Huber nico.huber@secunet.com --- M src/cpu/intel/Makefile.inc D src/cpu/intel/socket_BGA1284/Kconfig D src/cpu/intel/socket_BGA1284/Makefile.inc 3 files changed, 0 insertions(+), 19 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/31646/1

diff --git a/src/cpu/intel/Makefile.inc b/src/cpu/intel/Makefile.inc index 9535262..73a8bf8 100644 --- a/src/cpu/intel/Makefile.inc +++ b/src/cpu/intel/Makefile.inc @@ -6,7 +6,6 @@ subdirs-$(CONFIG_CPU_INTEL_FIRMWARE_INTERFACE_TABLE) += fit subdirs-$(CONFIG_CPU_INTEL_SOCKET_441) += socket_441 subdirs-$(CONFIG_CPU_INTEL_SOCKET_BGA956) += socket_BGA956 -subdirs-$(CONFIG_CPU_INTEL_SOCKET_BGA1284) += socket_BGA1284 subdirs-$(CONFIG_CPU_INTEL_SOCKET_FCBGA559) += socket_FCBGA559 subdirs-$(CONFIG_CPU_INTEL_SOCKET_M) += socket_m subdirs-$(CONFIG_CPU_INTEL_SOCKET_P) += socket_p diff --git a/src/cpu/intel/socket_BGA1284/Kconfig b/src/cpu/intel/socket_BGA1284/Kconfig deleted file mode 100644 index 402dc5c..0000000 --- a/src/cpu/intel/socket_BGA1284/Kconfig +++ /dev/null @@ -1,11 +0,0 @@ -config CPU_INTEL_SOCKET_BGA1284 - bool - -if CPU_INTEL_SOCKET_BGA1284 - -config SOCKET_SPECIFIC_OPTIONS # dummy - def_bool y - select MMX - select SSE - -endif diff --git a/src/cpu/intel/socket_BGA1284/Makefile.inc b/src/cpu/intel/socket_BGA1284/Makefile.inc deleted file mode 100644 index 539f285..0000000 --- a/src/cpu/intel/socket_BGA1284/Makefile.inc +++ /dev/null @@ -1,7 +0,0 @@ -subdirs-y += ../../x86/tsc -subdirs-y += ../../x86/mtrr -subdirs-y += ../../x86/lapic -subdirs-y += ../../x86/cache -subdirs-y += ../../x86/smm -subdirs-y += ../microcode -subdirs-y += ../turbo

Attachments:

attachment.htm (text/html — 4.4 KB)

Show replies by date

Arthur Heymans (Code Review)

27 Feb 27 Feb

11:18 p.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31646 )

Change subject: cpu/intel: Remove socket_BGA1284 ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31646 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea31e341c3df680ed48db4f8734d9d0bde120be3 Gerrit-Change-Number: 31646 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 27 Feb 2019 14:18:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

28 Feb 28 Feb

12:04 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31646 )

Change subject: cpu/intel: Remove socket_BGA1284 ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/31646 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea31e341c3df680ed48db4f8734d9d0bde120be3 Gerrit-Change-Number: 31646 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 27 Feb 2019 15:04:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

3:17 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31646 )

Change subject: cpu/intel: Remove socket_BGA1284 ......................................................................

Patch Set 1:

nano +21 src/cpu/intel/Kconfig

-- To view, visit https://review.coreboot.org/c/coreboot/+/31646 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea31e341c3df680ed48db4f8734d9d0bde120be3 Gerrit-Change-Number: 31646 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Wed, 27 Feb 2019 18:17:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

3:26 a.m.

Hello Patrick Rudolph, Arthur Heymans, Paul Menzel, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31646

to look at the new patch set (#2).

Change subject: cpu/intel: Remove socket_BGA1284 ......................................................................

cpu/intel: Remove socket_BGA1284

Unused since the removal of `fsp_sandybridge`.

Change-Id: Iea31e341c3df680ed48db4f8734d9d0bde120be3 Signed-off-by: Nico Huber nico.huber@secunet.com --- M src/cpu/intel/Kconfig M src/cpu/intel/Makefile.inc D src/cpu/intel/socket_BGA1284/Kconfig D src/cpu/intel/socket_BGA1284/Makefile.inc 4 files changed, 0 insertions(+), 20 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/31646/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31646 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea31e341c3df680ed48db4f8734d9d0bde120be3 Gerrit-Change-Number: 31646 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

3:26 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31646 )

Change subject: cpu/intel: Remove socket_BGA1284 ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31646 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea31e341c3df680ed48db4f8734d9d0bde120be3 Gerrit-Change-Number: 31646 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 27 Feb 2019 18:26:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

3:26 a.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31646 )

Change subject: cpu/intel: Remove socket_BGA1284 ......................................................................

Patch Set 2:

...

nano +21 src/cpu/intel/Kconfig

Thanks, Done, my grep'ing failed somehow :)

-- To view, visit https://review.coreboot.org/c/coreboot/+/31646 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea31e341c3df680ed48db4f8734d9d0bde120be3 Gerrit-Change-Number: 31646 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 27 Feb 2019 18:26:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

10:49 p.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31646 )

Change subject: cpu/intel: Remove socket_BGA1284 ......................................................................

cpu/intel: Remove socket_BGA1284

Unused since the removal of `fsp_sandybridge`.

Change-Id: Iea31e341c3df680ed48db4f8734d9d0bde120be3 Signed-off-by: Nico Huber nico.huber@secunet.com Reviewed-on: https://review.coreboot.org/c/31646 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/cpu/intel/Kconfig M src/cpu/intel/Makefile.inc D src/cpu/intel/socket_BGA1284/Kconfig D src/cpu/intel/socket_BGA1284/Makefile.inc 4 files changed, 0 insertions(+), 20 deletions(-)

Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved

diff --git a/src/cpu/intel/Kconfig b/src/cpu/intel/Kconfig index 10f7ad4..10fa701 100644 --- a/src/cpu/intel/Kconfig +++ b/src/cpu/intel/Kconfig @@ -18,7 +18,6 @@ # Sockets/Slots source src/cpu/intel/slot_1/Kconfig source src/cpu/intel/socket_BGA956/Kconfig -source src/cpu/intel/socket_BGA1284/Kconfig source src/cpu/intel/socket_FCBGA559/Kconfig source src/cpu/intel/socket_m/Kconfig source src/cpu/intel/socket_p/Kconfig diff --git a/src/cpu/intel/Makefile.inc b/src/cpu/intel/Makefile.inc index 9535262..73a8bf8 100644 --- a/src/cpu/intel/Makefile.inc +++ b/src/cpu/intel/Makefile.inc @@ -6,7 +6,6 @@ subdirs-$(CONFIG_CPU_INTEL_FIRMWARE_INTERFACE_TABLE) += fit subdirs-$(CONFIG_CPU_INTEL_SOCKET_441) += socket_441 subdirs-$(CONFIG_CPU_INTEL_SOCKET_BGA956) += socket_BGA956 -subdirs-$(CONFIG_CPU_INTEL_SOCKET_BGA1284) += socket_BGA1284 subdirs-$(CONFIG_CPU_INTEL_SOCKET_FCBGA559) += socket_FCBGA559 subdirs-$(CONFIG_CPU_INTEL_SOCKET_M) += socket_m subdirs-$(CONFIG_CPU_INTEL_SOCKET_P) += socket_p diff --git a/src/cpu/intel/socket_BGA1284/Kconfig b/src/cpu/intel/socket_BGA1284/Kconfig deleted file mode 100644 index 402dc5c..0000000 --- a/src/cpu/intel/socket_BGA1284/Kconfig +++ /dev/null @@ -1,11 +0,0 @@ -config CPU_INTEL_SOCKET_BGA1284 - bool - -if CPU_INTEL_SOCKET_BGA1284 - -config SOCKET_SPECIFIC_OPTIONS # dummy - def_bool y - select MMX - select SSE - -endif diff --git a/src/cpu/intel/socket_BGA1284/Makefile.inc b/src/cpu/intel/socket_BGA1284/Makefile.inc deleted file mode 100644 index 539f285..0000000 --- a/src/cpu/intel/socket_BGA1284/Makefile.inc +++ /dev/null @@ -1,7 +0,0 @@ -subdirs-y += ../../x86/tsc -subdirs-y += ../../x86/mtrr -subdirs-y += ../../x86/lapic -subdirs-y += ../../x86/cache -subdirs-y += ../../x86/smm -subdirs-y += ../microcode -subdirs-y += ../turbo

-- To view, visit https://review.coreboot.org/c/coreboot/+/31646 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea31e341c3df680ed48db4f8734d9d0bde120be3 Gerrit-Change-Number: 31646 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

2047

days inactive

2048

days old

coreboot-gerrit@coreboot.org

7 comments

5 participants

tags (0)

participants (5)

Arthur Heymans (Code Review)
HAOUAS Elyes (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)