Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/28767 )
Change subject: amd/stoneyridge: Load AOAC and USB gnvs values ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/28767/1/src/soc/amd/stoneyridge/southbridge.... File src/soc/amd/stoneyridge/southbridge.c:
https://review.coreboot.org/#/c/28767/1/src/soc/amd/stoneyridge/southbridge.... PS1, Line 914: 1;
Search for "AOACx[7F:41:step2] Device D3 State" in the NDA BKDG (probably also available in the publ […]
I'm aware of where the AOAC registers are defined, and I understand the aoac_device_enabled() intent. However, I pref using the device tree settings for these. They're probably more accurate a representation of the proper configuration.
-
Marshall Dawson (Code Review)