Attention is currently required from: Nico Huber, Tim Wawrzynczak.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62444 )
Change subject: mb/google/glados: Drop TPM PIRQ
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Hmmm, no saying I know better, but this would leave the GPIO […]
you're right, I should set the GPIOs to NC as well. I've done that here and the TPM still functions as expected (per cbmem and linux tpm_* commands)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62444
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I544695505291bbebe062df636cc8ddd139c08c2b
Gerrit-Change-Number: 62444
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 01 Mar 2022 18:00:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment