Attention is currently required from: Jonathan Zhang, Christian Walter, Angel Pons, Arthur Heymans, Tim Chu, Shelly Chang.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69146 )
Change subject: mb/ocp/deltalake: Add EWL Hob processing for MRC error
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69146/comment/61d343bb_98a3f06f
PS1, Line 9: Override the weak function mainboard_ewl_check() and
'disble' may be misspelled - perhaps 'disable'? […]
Done
https://review.coreboot.org/c/coreboot/+/69146/comment/b1e4b8a7_7218e97d
PS1, Line 10: The Intel FSP needs to disble promote
: MRC Warnings
Is this an UPD? Where is it set?
It's not in the public CedarIsland FSP. Please see my updated git comment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69146
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4419ef43815f8181af89c49514a69bdb29858c13
Gerrit-Change-Number: 69146
Gerrit-PatchSet: 2
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Comment-Date: Thu, 03 Nov 2022 11:08:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment