Change in coreboot[master]: mb/google/volteer/variant/lindar: Correct SD crad reader power sequen...
Kevin Chang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47799 )
Change subject: mb/google/volteer/variant/lindar: Correct SD crad reader power sequence for lindar ......................................................................
mb/google/volteer/variant/lindar: Correct SD crad reader power sequence for lindar
Modify SD card reader 3.3V power enable timing, add GPIO pin(GPP_D16) in GPIO early table..
BUG=b:173676531 BRANCH=firmware-volteer-13521.B TEST=Built and booted into OS, test USB function normally.
Change-Id: I0c536f36c138ace93766f3024f6ec5d47b38269f --- M src/mainboard/google/volteer/variants/lindar/gpio.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/47799/1
diff --git a/src/mainboard/google/volteer/variants/lindar/gpio.c b/src/mainboard/google/volteer/variants/lindar/gpio.c index 4f3d5f7..08f1401 100644 --- a/src/mainboard/google/volteer/variants/lindar/gpio.c +++ b/src/mainboard/google/volteer/variants/lindar/gpio.c @@ -134,6 +134,9 @@ /* C21 : UART2_TXD ==> H1_PCH_INT_ODL */ PAD_CFG_GPI_APIC(GPP_C21, NONE, PLTRST, LEVEL, INVERT),
+ /* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */ + PAD_CFG_GPO(GPP_D16, 1, DEEP), + /* H11 : SRCCLKREQ5# ==> WLAN_PERST_L */ PAD_CFG_GPO(GPP_H11, 1, DEEP), };
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47799
to look at the new patch set (#2).
Change subject: mb/google/volteer/variant/lindar: Correct SD crad reader power sequence for lindar ......................................................................
mb/google/volteer/variant/lindar: Correct SD crad reader power sequence for lindar
Modify SD card reader 3.3V power enable timing, add GPIO pin(GPP_D16) in GPIO early table..
BUG=b:173676531 BRANCH=firmware-volteer-13521.B TEST=Built and booted into OS, test USB function normally.
Change-Id: I0c536f36c138ace93766f3024f6ec5d47b38269f Signed-off-by: Kevin Chang kevin.chang@lcfc.corp-partner.google.com --- M src/mainboard/google/volteer/variants/lindar/gpio.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/47799/2
Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47799 )
Change subject: mb/google/volteer/variant/lindar: Correct SD crad reader power sequence for lindar ......................................................................
Patch Set 2: Code-Review+1
Already add signature
Kevin Chang has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/47799 )
Change subject: mb/google/volteer/variant/lindar: Correct SD crad reader power sequence for lindar ......................................................................
Removed Code-Review+1 by Kevin Chang kevin.chang@lcfc.corp-partner.google.com
Hello Caveh Jalali, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47799
to look at the new patch set (#3).
Change subject: mb/google/volteer/variant/lindar: Correct SD crad reader power sequence for lindar ......................................................................
mb/google/volteer/variant/lindar: Correct SD crad reader power sequence for lindar
Modify SD card reader 3.3V power enable timing, add GPIO pin(GPP_D16) in GPIO early table.
BUG=b:173676531 BRANCH=firmware-volteer-13521.B TEST=Built and booted into OS, test USB function normally.
Change-Id: I0c536f36c138ace93766f3024f6ec5d47b38269f Signed-off-by: Kevin Chang kevin.chang@lcfc.corp-partner.google.com --- M src/mainboard/google/volteer/variants/lindar/gpio.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/47799/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47799 )
Change subject: mb/google/volteer/variant/lindar: Correct SD crad reader power sequence for lindar ......................................................................
Patch Set 4: Code-Review+1
(4 comments)
LGTM, save for some nits in the commit message
https://review.coreboot.org/c/coreboot/+/47799/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47799/4//COMMIT_MSG@7 PS4, Line 7: crad typo: card
https://review.coreboot.org/c/coreboot/+/47799/4//COMMIT_MSG@7 PS4, Line 7: for lindar I would drop this part (already specified in the prefix)
https://review.coreboot.org/c/coreboot/+/47799/4//COMMIT_MSG@9 PS4, Line 9: in GPIO early table. please wrap commit messages at 72 characters
https://review.coreboot.org/c/coreboot/+/47799/4//COMMIT_MSG@9 PS4, Line 9: (GPP_D16) nit: no parentheses here
Hello build bot (Jenkins), Furquan Shaikh, Caveh Jalali, Angel Pons, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47799
to look at the new patch set (#5).
Change subject: mb/google/volteer/variant/lindar: Correct SD card reader power sequence ......................................................................
mb/google/volteer/variant/lindar: Correct SD card reader power sequence
Modify SD card reader 3.3V power enable timing, add GPP_D16 in GPIO early table.
BUG=b:173676531 BRANCH=firmware-volteer-13521.B TEST=Built and booted into OS, test USB function normally.
Change-Id: I0c536f36c138ace93766f3024f6ec5d47b38269f Signed-off-by: Kevin Chang kevin.chang@lcfc.corp-partner.google.com --- M src/mainboard/google/volteer/variants/lindar/gpio.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/47799/5
Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47799 )
Change subject: mb/google/volteer/variant/lindar: Correct SD card reader power sequence ......................................................................
Patch Set 5:
(4 comments)
Hi Angel
Updated in patch.
https://review.coreboot.org/c/coreboot/+/47799/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47799/4//COMMIT_MSG@7 PS4, Line 7: for lindar
I would drop this part (already specified in the prefix)
Done
https://review.coreboot.org/c/coreboot/+/47799/4//COMMIT_MSG@7 PS4, Line 7: crad
typo: card
Done
https://review.coreboot.org/c/coreboot/+/47799/4//COMMIT_MSG@9 PS4, Line 9: (GPP_D16)
nit: no parentheses here
Done
https://review.coreboot.org/c/coreboot/+/47799/4//COMMIT_MSG@9 PS4, Line 9: in GPIO early table.
please wrap commit messages at 72 characters
Done
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47799 )
Change subject: mb/google/volteer/variant/lindar: Correct SD card reader power sequence ......................................................................
Patch Set 5:
Why this patch is needed? I don't see any reason in the bug. Could you please describe it more clearly?
Hello build bot (Jenkins), Furquan Shaikh, Caveh Jalali, Angel Pons, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47799
to look at the new patch set (#6).
Change subject: mb/google/volteer/variant/lindar: Correct SD card reader power sequence ......................................................................
mb/google/volteer/variant/lindar: Correct SD card reader power sequence
According to Bayhub provided SPEC, 3.3V power need lead than PE_RST over 100ms. Modify SD card reader 3.3V power enable timing, add GPP_D16 in GPIO early table.
BUG=b:173676531 BRANCH=firmware-volteer-13521.B TEST=Built and booted into OS, test USB function normally.
Change-Id: I0c536f36c138ace93766f3024f6ec5d47b38269f Signed-off-by: Kevin Chang kevin.chang@lcfc.corp-partner.google.com --- M src/mainboard/google/volteer/variants/lindar/gpio.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/47799/6
Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47799 )
Change subject: mb/google/volteer/variant/lindar: Correct SD card reader power sequence ......................................................................
Patch Set 6:
Patch Set 5:
Why this patch is needed? I don't see any reason in the bug. Could you please describe it more clearly?
Hi Zhuohao
Updated in patch 6.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47799 )
Change subject: mb/google/volteer/variant/lindar: Correct SD card reader power sequence ......................................................................
Patch Set 6: Code-Review+1
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47799 )
Change subject: mb/google/volteer/variant/lindar: Correct SD card reader power sequence ......................................................................
Patch Set 6:
(1 comment)
Is there a minimum power off time for the device?
https://review.coreboot.org/c/coreboot/+/47799/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47799/6//COMMIT_MSG@9 PS6, Line 9: According to Bayhub provided SPEC, 3.3V power need lead than PE_RST over 100ms. suggestion: ``` According to the spec provided by Bayhub, the 3.3V power rail must be enabled at least 100ms before reset is released. To ensure this, set the power enable signal in the bootblock GPIO table.
Hello build bot (Jenkins), Furquan Shaikh, Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro, Angel Pons, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47799
to look at the new patch set (#7).
Change subject: mb/google/volteer/variant/lindar: Correct SD card reader power sequence ......................................................................
mb/google/volteer/variant/lindar: Correct SD card reader power sequence
According to the spec provided by Bayhub, the 3.3V power rail must be enabled at least 100ms before reset is released. To ensure this, set the power enable signal in the bootblock GPIO table.
BUG=b:173676531 BRANCH=firmware-volteer-13521.B TEST=Built and booted into OS, test USB function normally.
Change-Id: I0c536f36c138ace93766f3024f6ec5d47b38269f Signed-off-by: Kevin Chang kevin.chang@lcfc.corp-partner.google.com --- M src/mainboard/google/volteer/variants/lindar/gpio.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/47799/7
Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47799 )
Change subject: mb/google/volteer/variant/lindar: Correct SD card reader power sequence ......................................................................
Patch Set 7:
(1 comment)
Hi Tim
Updated in patchset 6.
https://review.coreboot.org/c/coreboot/+/47799/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47799/6//COMMIT_MSG@9 PS6, Line 9: According to Bayhub provided SPEC, 3.3V power need lead than PE_RST over 100ms.
suggestion: […]
Done
Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47799 )
Change subject: mb/google/volteer/variant/lindar: Correct SD card reader power sequence ......................................................................
Patch Set 7:
Patch Set 7:
(1 comment)
Hi Tim
Updated in patchset 7.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47799 )
Change subject: mb/google/volteer/variant/lindar: Correct SD card reader power sequence ......................................................................
Patch Set 7: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47799 )
Change subject: mb/google/volteer/variant/lindar: Correct SD card reader power sequence ......................................................................
mb/google/volteer/variant/lindar: Correct SD card reader power sequence
According to the spec provided by Bayhub, the 3.3V power rail must be enabled at least 100ms before reset is released. To ensure this, set the power enable signal in the bootblock GPIO table.
BUG=b:173676531 BRANCH=firmware-volteer-13521.B TEST=Built and booted into OS, test USB function normally.
Change-Id: I0c536f36c138ace93766f3024f6ec5d47b38269f Signed-off-by: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47799 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/lindar/gpio.c 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/lindar/gpio.c b/src/mainboard/google/volteer/variants/lindar/gpio.c index 4f3d5f7..08f1401 100644 --- a/src/mainboard/google/volteer/variants/lindar/gpio.c +++ b/src/mainboard/google/volteer/variants/lindar/gpio.c @@ -134,6 +134,9 @@ /* C21 : UART2_TXD ==> H1_PCH_INT_ODL */ PAD_CFG_GPI_APIC(GPP_C21, NONE, PLTRST, LEVEL, INVERT),
+ /* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */ + PAD_CFG_GPO(GPP_D16, 1, DEEP), + /* H11 : SRCCLKREQ5# ==> WLAN_PERST_L */ PAD_CFG_GPO(GPP_H11, 1, DEEP), };
-
Angel Pons (Code Review) -
Kevin Chang (Code Review)
-
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)
-
Zhuohao Lee (Code Review)