Attention is currently required from: Sean Rhodes, Martin Roth, Matt DeVillier, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 )
Change subject: [WIP] util: Add coreboot Configurator ......................................................................
Patch Set 25:
(352 comments)
File util/coreboot-configurator/src/application/aboutwindow.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ad7076ce_32d06c99 PS25, Line 16: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/68a63273_9906f9b2 PS25, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b4071d5e_9869fdf2 PS25, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b1663f39_9a0caa61 PS25, Line 21: Ui::aboutWindow *ui; labels should not be indented
File util/coreboot-configurator/src/application/configuration.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/2fb7820b_e9bbe7d6 PS25, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/98ab642b_99e8277c PS25, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/56045b59_9d2e2eed PS25, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e0bd50de_8e2dcea7 PS25, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/06232ff8_925cacf5 PS25, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/0439e317_4cfd0017 PS25, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/52a1969c_f9564562 PS25, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1fa871cf_677348e8 PS25, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/46729727_8ba6ae26 PS25, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1be50948_148abc6d PS25, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW)
File util/coreboot-configurator/src/application/coreboot_configurator.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e982f9ab_bcb1e317 PS25, Line 29: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/eba25fb5_e9f49f08 PS25, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b319599e_148f489f PS25, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/693b7a12_3c5e77c5 PS25, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e4ce6585_ae5977e9 PS25, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/21daed3d_962143f3 PS25, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/9cb61327_991903fc PS25, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1884c3ee_7d4245eb PS25, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/977fc3fd_22d0b3df PS25, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/586c89a7_63cb23df PS25, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6cf40294_a94af404 PS25, Line 67: YAML::Node m_categories; labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/bfbe93e6_f826816c PS25, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/c7014c91_fdc66e90 PS25, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/18d31777_57897b7a PS25, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/55968632_07df287a PS25, Line 73: Ui::coreboot_configurator *ui; labels should not be indented
File util/coreboot-configurator/src/application/coreboot_configurator.cpp:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/2984bb2c_d36787fd PS25, Line 206: trailing whitespace
File util/coreboot-configurator/src/application/qtyaml.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/d5bd9a30_05294409 PS25, Line 30: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/78fde81a_1d507dd2 PS25, Line 30: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/702bb4c4_7f422a97 PS25, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/178804dd_bae2d265 PS25, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/522dddf7_4234e69e PS25, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1be0c745_eee2457d PS25, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/78f3fdf7_489691c0 PS25, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7dce3ed1_7407dba2 PS25, Line 34: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/95cf516c_8afea877 PS25, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/33fdea8e_b3464cc6 PS25, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/be3e0754_c39e7818 PS25, Line 36: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4ceec24e_1f5a2caf PS25, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/848bb3a7_6e3b61b7 PS25, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/db27fd41_4cf631e9 PS25, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/fd018052_86ff38d2 PS25, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4b75f10e_c5404262 PS25, Line 39: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/8be52993_7667313b PS25, Line 40: if (!node.IsScalar()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a5ecaf10_92b76dfa PS25, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/3a0a3f79_b5383bcc PS25, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5df4943b_8f2739f3 PS25, Line 41: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f9e5b176_2c7b9ca6 PS25, Line 41: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/9cc6e045_8b18748e PS25, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6388aef2_24d141ae PS25, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/3697e992_47a4afbd PS25, Line 43: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/8e4e9e32_fd84f6ef PS25, Line 43: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f340334b_fab9f86d PS25, Line 44: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/d3dcb132_8a4f869e PS25, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/3f820344_0f6e6333 PS25, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/c643788c_cf742b04 PS25, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/351baa20_d84e44c8 PS25, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/cc8cb90f_25a1dba8 PS25, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5789b72d_d9417055 PS25, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1c1772bd_efb31365 PS25, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4ab3a706_2f1fe2a5 PS25, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/98f172f6_03abc2a4 PS25, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/cc1db550_878f1447 PS25, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/549d746c_88c76c72 PS25, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/522b5ef7_53cbe7d9 PS25, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1a3673cf_5e15e233 PS25, Line 52: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ddd33c62_c8717821 PS25, Line 53: Node node(NodeType::Map); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ef65c9e8_f6a72f07 PS25, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/d5599501_1599532a PS25, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/c4cd8fab_c0718e40 PS25, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4132d2b8_70e56704 PS25, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f8b1ef69_31ef936c PS25, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4c913717_d23fd41e PS25, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1c91e3d4_d5d31ae3 PS25, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b9932f07_5b0987e8 PS25, Line 56: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/df4120b2_b331c6a5 PS25, Line 56: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/11719c77_524eae38 PS25, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/abf31415_5e3033d1 PS25, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/3ffc4d3e_e88a62fb PS25, Line 58: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/60956816_6258c6bb PS25, Line 58: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/62a1ef14_8ebb4cf9 PS25, Line 59: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/86c414e4_7948afa7 PS25, Line 59: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7932b3e6_ed91b9ed PS25, Line 60: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e04aa2a5_766927da PS25, Line 60: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/13a57f5e_32edbe72 PS25, Line 61: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f8b84799_1f2b9fd2 PS25, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/d793e2a1_1aed7a3e PS25, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/24726d7e_1ecf4019 PS25, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/bc44f7de_2596bc20 PS25, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/eeb90002_077bc4af PS25, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/0a1439a1_25cbd32d PS25, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/022cf827_cd66b1cf PS25, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/30e7c5f7_e681e28e PS25, Line 64: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7096dfbf_4cc6ba7e PS25, Line 65: if (!node.IsMap()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5ecbeed1_34bb923c PS25, Line 65: if (!node.IsMap()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7c60eedf_78481991 PS25, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/fb95bfe8_9979610f PS25, Line 66: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4f2f05da_5bcbd20e PS25, Line 66: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b573fb4c_2b809722 PS25, Line 68: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/26783b82_b856bc2a PS25, Line 68: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b8438c13_b642ac18 PS25, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/da510960_0713eb24 PS25, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7c5349a2_3c26eda7 PS25, Line 70: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/acdc6444_6f880465 PS25, Line 70: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/bcf7c45a_88a90359 PS25, Line 70: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/18d52ec3_b6827e74 PS25, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/c69b45f0_16243102 PS25, Line 71: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/eed9e5bc_577720c8 PS25, Line 71: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/2c7a0b13_a6a59f95 PS25, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/3960d0d8_3ccb090e PS25, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a187f35d_6dd61421 PS25, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b92779e4_b3a5359a PS25, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f9fd4c4a_00ff8206 PS25, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7f8a2429_7a90526b PS25, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/778ab9cb_0aa599cc PS25, Line 73: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/25c459c7_9cceb3fa PS25, Line 73: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ead99ffa_39ccb75f PS25, Line 74: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f1175e2f_418c594b PS25, Line 74: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/3c1831ef_d4b1950a PS25, Line 75: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/72cf1e44_7280b561 PS25, Line 75: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5a99ebcf_4259354f PS25, Line 76: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ab7cacb3_b086b653 PS25, Line 80: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/391aab7f_e76b5584 PS25, Line 80: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f5c63a45_4f3965a7 PS25, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/cc59d148_6d7fce37 PS25, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/2de9915e_145e20ef PS25, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/bfc3130e_590901f8 PS25, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5b5b4d5a_b5eef4a1 PS25, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/21ca1646_3af9b2a3 PS25, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5b77c10e_459397ab PS25, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/eed52860_5019f913 PS25, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4eed9a33_07b1fd65 PS25, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/08189acf_e0fee97f PS25, Line 84: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/db224a06_231352d3 PS25, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/68cebc8d_a08bb697 PS25, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/585f3f33_fe6f32b8 PS25, Line 86: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/fb445b6b_034a111d PS25, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5de69c42_77811541 PS25, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a44f7c5c_020745f2 PS25, Line 87: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/fb62619c_fe93687f PS25, Line 87: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/bf675e9e_963ddb8a PS25, Line 88: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1b1d77c9_0872ed80 PS25, Line 88: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/12de161e_559ec80d PS25, Line 89: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/68fb92c4_3cb5f0a4 PS25, Line 89: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/62ca6ec5_ad7b4d6e PS25, Line 90: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/244115a6_b2cf13df PS25, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6614ac28_f98aab1e PS25, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/df09ca29_8f3fbd8a PS25, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a9c5c5e1_7d685547 PS25, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/605d3f11_0c2e7b5c PS25, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/c5d5b475_a4778416 PS25, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/9b0e7410_1abd330b PS25, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f1ab6ae9_e2234dd8 PS25, Line 93: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/d6228947_adb20c93 PS25, Line 94: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5b7ef7ac_93e581aa PS25, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/d717672d_e0dc91ae PS25, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6a0aceba_37991146 PS25, Line 95: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/74b505b9_ebb00b9d PS25, Line 95: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a22d52c8_ea10bbf2 PS25, Line 97: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5ee00936_608498a1 PS25, Line 97: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/17c056ea_070aa346 PS25, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/d7027bad_677647d0 PS25, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1c67047b_164d20a5 PS25, Line 99: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/2820d847_60d4fb59 PS25, Line 99: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/69188115_9bd38ea6 PS25, Line 99: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ad65641f_363540d5 PS25, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/84fea297_e5e9d32a PS25, Line 100: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/bc941cb5_ce97a457 PS25, Line 100: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5589e2c1_d44b549d PS25, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/404b85fa_ac9ae868 PS25, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1259def7_39c8f454 PS25, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/79ee93b9_cd70a4e6 PS25, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/11480ed3_de8f018e PS25, Line 102: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7794d434_9d558d8e PS25, Line 102: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/557b8a03_9c148081 PS25, Line 103: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/447786c5_b6963ae8 PS25, Line 103: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1f27e21e_954c8b00 PS25, Line 104: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f223045e_c9ad02f1 PS25, Line 104: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1540f5c4_56a920fa PS25, Line 105: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/97dfb560_0f4f06b2 PS25, Line 109: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/268987d5_567347f0 PS25, Line 109: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/cfb6e8ea_be39fa91 PS25, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e8f7ccda_cc14626e PS25, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/956d8896_9debaf16 PS25, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/61df1c1b_ce21886d PS25, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/59218f8b_9a6684ba PS25, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/45416dc3_ba6c41d1 PS25, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/94be27ba_4c1dc145 PS25, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7616700e_73ba3855 PS25, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7312201d_be69e936 PS25, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/0507bf23_75471fa0 PS25, Line 113: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a8864106_e6c720d2 PS25, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b640024a_004610e4 PS25, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/bcf01ded_4dec7a92 PS25, Line 115: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/92f3d339_a5fcb0ca PS25, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6d232965_f6fee811 PS25, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/469c9808_62a49650 PS25, Line 116: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/352fad86_be231c4a PS25, Line 116: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7a5548b8_89507e61 PS25, Line 117: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/47ee9ea3_c9e00433 PS25, Line 117: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b48ad44d_f9007f59 PS25, Line 118: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/68e9b08f_177db308 PS25, Line 118: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/46763acb_35a08fcb PS25, Line 119: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ad2ab67f_6490790e PS25, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/48b8b039_c867b763 PS25, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/462a5028_204b464b PS25, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6b4fea6a_d6d14524 PS25, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/8248e974_52604aba PS25, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/20ae900c_74ce142f PS25, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/cd5e23e1_74ef9d5d PS25, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b385e5e4_38bfc9b2 PS25, Line 122: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b5238b85_46d9e805 PS25, Line 123: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5c298f41_ecd90df0 PS25, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/82d40ffc_51121a23 PS25, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/591ad8eb_c11499d3 PS25, Line 124: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/10c52059_32e03857 PS25, Line 124: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a60e49c2_52eb6cfe PS25, Line 126: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/acd9dc54_24d957de PS25, Line 126: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/38b6d927_76796ee9 PS25, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/cbe8a19d_bc87c71d PS25, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a69acef5_bca0e104 PS25, Line 128: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/8831e1d9_8a105f4f PS25, Line 128: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ebdcbbda_72465d5f PS25, Line 128: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/8eae6912_8fca958d PS25, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/01afb4a4_691ca09f PS25, Line 129: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ab320232_3ab0f961 PS25, Line 129: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/8fcafc42_79992658 PS25, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/69e9e7ec_704f5258 PS25, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/783824a0_d392e1bf PS25, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/cc34f7b9_d6df6404 PS25, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/3338be62_d67aac6f PS25, Line 131: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/632eebf0_885edf48 PS25, Line 131: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7e68505a_1765537a PS25, Line 132: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/35fafaa6_981bdb49 PS25, Line 132: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/38a26993_e8b01ea1 PS25, Line 133: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/9d9d2f83_ceb23f60 PS25, Line 133: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e63401c7_eb7820dc PS25, Line 134: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a181ed9e_0b26f70a PS25, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f886a9d5_bdcb3a1c PS25, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/56f772aa_dcba407b PS25, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6411ed0e_38407708 PS25, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e1e8796f_6703b364 PS25, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/dcef40c1_8434bd06 PS25, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6dac2c32_ac065fd0 PS25, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/9e753363_da7d4544 PS25, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/785b1116_2de7a65a PS25, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/575c7c4d_f6817799 PS25, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/42465492_7d24f839 PS25, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4c3d9d4f_ac45a5b0 PS25, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e8a2123b_14e08d38 PS25, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f21c353a_d2f4c477 PS25, Line 142: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7c3b228f_7be7169a PS25, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/0ad05e7b_82d097b6 PS25, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4077d75c_57bea6ac PS25, Line 144: node.push_back(rhs.first); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/14977fb3_1638c6d4 PS25, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ebd01c62_6db76ea7 PS25, Line 145: node.push_back(rhs.second); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/df574840_414d8df9 PS25, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/2486be53_1bfcd2b8 PS25, Line 146: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/09b697e8_743f3f5f PS25, Line 146: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f4f8defd_5d515f7d PS25, Line 147: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4f5b74c4_0a4db3ea PS25, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/2dac5a4f_d7e1f0b9 PS25, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6ef3b360_e477372c PS25, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4e02e909_3e0eb7dc PS25, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/9ad09455_c2d4d456 PS25, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b7a1bb76_0b9c50ae PS25, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/3ed78d09_09254fb0 PS25, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b180696c_d12e2bc6 PS25, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/55e7407e_b3dfe847 PS25, Line 150: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/88cd8159_cc34e176 PS25, Line 151: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/38953f55_3beb4d52 PS25, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4ab2e8ef_3177a9af PS25, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a9f70c4b_369b12e0 PS25, Line 152: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/bd6bfa24_c724df82 PS25, Line 152: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/8b81bd9e_f8e4f7ff PS25, Line 153: if (node.size() != 2) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a537694a_2d78fc5e PS25, Line 153: if (node.size() != 2) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/05dd994b_45c296bf PS25, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a88fcb25_8fe26840 PS25, Line 154: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/61c5c073_9d2bb025 PS25, Line 154: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e1e1e48e_7a8b5237 PS25, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e1e98baa_ffd74cd9 PS25, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a4021057_7a35159d PS25, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/349c8452_801dcadd PS25, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/9b46d070_ec49921e PS25, Line 157: rhs.second = node[1].as<U>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/3260487c_11c345ff PS25, Line 157: rhs.second = node[1].as<U>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/0d74425c_fb8e6f62 PS25, Line 157: rhs.second = node[1].as<U>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/62e61d18_fda3acab PS25, Line 157: rhs.second = node[1].as<U>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/8adfcd30_d555942b PS25, Line 158: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5fce273a_a371f158 PS25, Line 158: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f9c1a888_e996f893 PS25, Line 159: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/26d508c8_5f66834d PS25, Line 163: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b9b6b619_948f7df2 PS25, Line 163: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/3cacaa71_c002fdc3 PS25, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b4c0d64b_c9101b0c PS25, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/7d9e3b39_3d8010b3 PS25, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6d220b8d_c83ae1d2 PS25, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1a214d16_11dd1791 PS25, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/517cb9ae_1cff2cca PS25, Line 167: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b77439f0_fd559286 PS25, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/bbf40b2b_813a67ee PS25, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/90576744_753f7af1 PS25, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a80141e2_ea76d72f PS25, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/be8e1bdc_c2861817 PS25, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ec5c1b1e_3b105ce1 PS25, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1ffad4e2_482c4c31 PS25, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/11343a80_0af8dda0 PS25, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/0771efef_5342653d PS25, Line 170: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/290b92b2_5a119bc4 PS25, Line 170: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/539e06ff_c1a43632 PS25, Line 171: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/c18ebebd_d06ee5d4 PS25, Line 171: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/bec78132_e2adf64c PS25, Line 172: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b0306bbb_5b4c0c71 PS25, Line 172: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/1f8e952c_b8a6a578 PS25, Line 173: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/58d72e6a_76d3255d PS25, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/63557f6a_088bf289 PS25, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ae654daf_326c602e PS25, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/889eee77_c832a182 PS25, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ac565f90_0c2df157 PS25, Line 176: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/2c8688fc_d67f8c55 PS25, Line 177: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/5ce0ff4a_932d8f96 PS25, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/9a2dcef5_b157a951 PS25, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/a09c3a66_3f8aafd6 PS25, Line 178: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/57e494be_d9fbba48 PS25, Line 178: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/c374d547_49089340 PS25, Line 180: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6e43a4cd_d0816120 PS25, Line 180: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/83990f19_2773338b PS25, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/c4a7cc88_680644c5 PS25, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/689f76e4_afce7cd0 PS25, Line 182: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6c4b863a_e366ca7e PS25, Line 182: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/349ce720_d02c2f98 PS25, Line 182: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/aa1f8031_0dd64c96 PS25, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/c789ac7d_bddf138c PS25, Line 183: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/2861cfc4_5b9cd530 PS25, Line 183: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/dcd9c2b3_3e0a5234 PS25, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4686b791_0af0d311 PS25, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/62111566_bed29460 PS25, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/dffa1c18_49287778 PS25, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/f330e5d3_dc552064 PS25, Line 185: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/30bad287_02b3a642 PS25, Line 185: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/4f2aa055_a5f4dde3 PS25, Line 186: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/991a58b4_4cfc199d PS25, Line 186: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/417e5bd6_57f0aab9 PS25, Line 187: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/246dc568_57d2adda PS25, Line 187: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/b8e3ba27_9c386aae PS25, Line 188: } please, no spaces at the start of a line
File util/coreboot-configurator/src/application/toggleswitch.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/ccbb5562_8f17ad73 PS25, Line 16: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/703d39e8_cfa697b5 PS25, Line 17: explicit ToggleSwitch(QWidget* parent = nullptr); need consistent spacing around '*' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/6dad9367_ad8665bc PS25, Line 25: void recolorToggleOn(const QPalette& palette); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/e949fc26_bce03e05 PS25, Line 30: void paintEvent(QPaintEvent *event) override; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132359): https://review.coreboot.org/c/coreboot/+/58854/comment/038a3cc4_4826d5c4 PS25, Line 34: bool hitButton(const QPoint &pos) const override need consistent spacing around '&' (ctx:WxV)
-
build bot (Jenkins) (Code Review)