Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39092 )
Change subject: mb/supermicro/x11-lga1151-series: devicetree: fix iLPC2AHB irq
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39092/1/src/mainboard/supermicro/x1...
File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39092/1/src/mainboard/supermicro/x1...
PS1, Line 109: irq 0x70 = 0x0
I couldn't find a reference in the Aspeed datasheet that "0" means disable and INT0 is assigned to t […]
Yep, I just set what the vendor set - we could use another value as well here - suggestions?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39092
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc1cd04e995d68f4c779e9aa9c09bb7bf9f26363
Gerrit-Change-Number: 39092
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 24 Feb 2020 16:13:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Michael Niewöhner
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment