Attention is currently required from: Michał Żygowski, Michał Kopeć. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63490 )
Change subject: mb/msi/ms7d25: add GPIO configuration ......................................................................
Patch Set 16: Verified+1
(15 comments)
File src/mainboard/msi/ms7d25/gpio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150190): https://review.coreboot.org/c/coreboot/+/63490/comment/05bad0e4_9e987009 PS16, Line 136: _PAD_CFG_STRUCT(VGPIO_0, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_BUF(RX_DISABLE) | 1, 0), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150190): https://review.coreboot.org/c/coreboot/+/63490/comment/cdadcbca_e6afa204 PS16, Line 137: _PAD_CFG_STRUCT(VGPIO_4, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150190): https://review.coreboot.org/c/coreboot/+/63490/comment/c19b0177_77874f18 PS16, Line 138: _PAD_CFG_STRUCT(VGPIO_5, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_BUF(RX_DISABLE) | 1, 0), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150190): https://review.coreboot.org/c/coreboot/+/63490/comment/f6650b26_9c122ff3 PS16, Line 143: _PAD_CFG_STRUCT(VGPIO_10, PAD_FUNC(NF1) | PAD_RESET(DEEP) | (1 << 1), 0), /* VGPIO_10 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150190): https://review.coreboot.org/c/coreboot/+/63490/comment/9a2af67e_ae0754a3 PS16, Line 146: _PAD_CFG_STRUCT(VGPIO_13, PAD_FUNC(NF1) | PAD_RESET(DEEP) | (1 << 1), 0), /* VGPIO_13 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150190): https://review.coreboot.org/c/coreboot/+/63490/comment/c877633a_50c45918 PS16, Line 151: _PAD_CFG_STRUCT(VGPIO_22, PAD_FUNC(NF1) | PAD_RESET(DEEP) | (1 << 1), 0), /* VGPIO_22 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150190): https://review.coreboot.org/c/coreboot/+/63490/comment/4dfe40b7_304a517f PS16, Line 154: _PAD_CFG_STRUCT(VGPIO_25, PAD_FUNC(NF1) | PAD_RESET(DEEP) | (1 << 1), 0), /* VGPIO_25 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150190): https://review.coreboot.org/c/coreboot/+/63490/comment/ac74ca02_fc6be8c5 PS16, Line 165: _PAD_CFG_STRUCT(VGPIO_USB_0, PAD_FUNC(NF1) | PAD_RESET(DEEP), 0), /* VGPIO_USB_0 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150190): https://review.coreboot.org/c/coreboot/+/63490/comment/97a65a63_6ef53a4a PS16, Line 166: _PAD_CFG_STRUCT(VGPIO_USB_1, PAD_FUNC(NF1) | PAD_RESET(DEEP), 0), /* VGPIO_USB_1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150190): https://review.coreboot.org/c/coreboot/+/63490/comment/56f986cd_c41734d6 PS16, Line 167: _PAD_CFG_STRUCT(VGPIO_USB_2, PAD_FUNC(NF1) | PAD_RESET(DEEP), 0), /* VGPIO_USB_2 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150190): https://review.coreboot.org/c/coreboot/+/63490/comment/3bc0913d_faf13838 PS16, Line 168: _PAD_CFG_STRUCT(VGPIO_USB_3, PAD_FUNC(NF1) | PAD_RESET(DEEP), 0), /* VGPIO_USB_3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150190): https://review.coreboot.org/c/coreboot/+/63490/comment/ebb9ddb9_c2c42aee PS16, Line 169: _PAD_CFG_STRUCT(VGPIO_USB_8, PAD_FUNC(NF1) | PAD_RESET(DEEP) | (1 << 1), 0), /* VGPIO_USB_8 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150190): https://review.coreboot.org/c/coreboot/+/63490/comment/b221c4b8_9df8ae6e PS16, Line 170: _PAD_CFG_STRUCT(VGPIO_USB_9, PAD_FUNC(NF1) | PAD_RESET(DEEP) | (1 << 1), 0), /* VGPIO_USB_9 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150190): https://review.coreboot.org/c/coreboot/+/63490/comment/4f15d26f_72ccc19d PS16, Line 171: _PAD_CFG_STRUCT(VGPIO_USB_10, PAD_FUNC(NF1) | PAD_RESET(DEEP) | (1 << 1), 0), /* VGPIO_USB_10 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150190): https://review.coreboot.org/c/coreboot/+/63490/comment/8d514c1b_a261135f PS16, Line 172: _PAD_CFG_STRUCT(VGPIO_USB_11, PAD_FUNC(NF1) | PAD_RESET(DEEP) | (1 << 1), 0), /* VGPIO_USB_11 */ line over 96 characters
-
build bot (Jenkins) (Code Review)