build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37871 )
Change subject: soc/intel/common/block: Enable PMC IPC driver in Coreboot ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37871/5/src/soc/intel/common/block/... File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/37871/5/src/soc/intel/common/block/... PS5, Line 617: stopwatch_duration_msecs(&sw)); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37871/5/src/soc/intel/common/block/... PS5, Line 617: stopwatch_duration_msecs(&sw)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37871/5/src/soc/intel/common/block/... PS5, Line 622: int pmc_send_ipc_cmd (uint32_t cmd, uint32_t sub, uint8_t *in, uint32_t inlen, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/37871/5/src/soc/intel/common/block/... PS5, Line 644: if(check_ips_sts(pmcbase)) { space required before the open parenthesis '('
-
build bot (Jenkins) (Code Review)