[S] Change in coreboot[main]: mb/google/rex/var/rex: Configure PL4 to 64W if battery status is invalid
Attention is currently required from: Brandon Breitenstein, Caveh Jalali, Eran Mitrani, Hannah Williams, Kapil Porwal, Subrata Banik, Sukumar Ghorai, Tarun.
Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78322?usp=email )
Change subject: mb/google/rex/var/rex: Configure PL4 to 64W if battery status is invalid ......................................................................
Patch Set 5:
(4 comments)
File src/mainboard/google/rex/variants/baseboard/rex/ramstage.c:
https://review.coreboot.org/c/coreboot/+/78322/comment/aad37dcc_e19df0d7 : PS5, Line 13: limits
rename this to `performance_efficient_limits`` in one CL
Acknowledged
https://review.coreboot.org/c/coreboot/+/78322/comment/04185f35_818e6e18 : PS5, Line 25: p
what is lp ? low_power ? […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/78322/comment/bdb7fc18_f3519ea8 : PS5, Line 42: printk(BIOS_ERR, "Failed to read EC battery info\n");
what is the fallback when battery info check is failing ? just continue ?
I was thinking to let the boot flow goes with power_optimized_limits profile, but if you have a suggestion, please let me know. Thanks.
https://review.coreboot.org/c/coreboot/+/78322/comment/5922e3bb_3e0b05a3 : PS5, Line 48: battery_status
the battery_status is only reading if the returned value from the host command is 0 see https://revi […]
What is the condition we are going to check to limit PL4 now? Are we going to consider Battery level as well? And does EC allow the platform to boot when LEVEL_CRITICAL is set? As Brandon mentioned, if battery is cut off or battery is not physically present, I see dynamic battery flags(battery_status) is returned 0x0. I will update to limit the check to run for chromeec only. Thanks for the comments.
-
Jamie Ryu (Code Review)