[S] Change in coreboot[main]: [RFC] device/resource: IOINDEX_SUBTRACTIVE oddities - coreboot-gerrit

8 Nov 2024


      Attention is currently required from: Kyösti Mälkki.
Yu-Ping Wu has posted comments on this change by Kyösti Mälkki. ( https://review.coreboot.org/c/coreboot/+/64972?usp=email )
Change subject: [RFC] device/resource: IOINDEX_SUBTRACTIVE oddities
......................................................................
Patch Set 6:
(1 comment)
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/64972/comment/272cedd1_ac7e94c0?usp... :
PS6, Line 179: 	res->size = conf->mmio_res_io.size;
Despite of many unrelated changes, this patch mainly does two things:
1. Replace `res->limit` assignment with `res->size`
2. Add `IORESOURCE_FIXED` to `res->flags`
Could you please explain the reason in the commit message?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/64972?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieff703ed39d69c8ef9edb2e8292ce82eb4e41351
Gerrit-Change-Number: 64972
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin hungte@chromium.org
Gerrit-CC: Martin L Roth gaumless@gmail.com
Gerrit-CC: Xi Chen xixi.chen@mediatek.com
Gerrit-CC: Yidi Lin yidilin@google.com
Gerrit-CC: Yu-Ping Wu yupingso@google.com
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 08 Nov 2024 07:35:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No