Tao Xia has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44061 )
Change subject: mb/google/kukui: Add a new config 'Fennel' ......................................................................
mb/google/kukui: Add a new config 'Fennel'
A new board introduced to Kukui family.
BUG=b:162042552 TEST=make # select Fennel BRANCH=kukui
Signed-off-by: xiatao5 xiatao5@huaqin.corp-partner.google.com Change-Id: I1f742a36793f38c37fbd4e1b4cbddbd542e785ec --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/44061/1
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 906dfea..e06e60f 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -57,6 +57,7 @@ default "Willow" if BOARD_GOOGLE_WILLOW default "Esche" if BOARD_GOOGLE_ESCHE default "Burnet" if BOARD_GOOGLE_BURNET + default "Fennel" if BOARD_GOOGLE_FENNEL
config DRIVER_TPM_SPI_BUS hex diff --git a/src/mainboard/google/kukui/Kconfig.name b/src/mainboard/google/kukui/Kconfig.name index 77cdc67..3558113 100644 --- a/src/mainboard/google/kukui/Kconfig.name +++ b/src/mainboard/google/kukui/Kconfig.name @@ -57,3 +57,7 @@ config BOARD_GOOGLE_BURNET bool "-> Burnet" select BOARD_GOOGLE_JACUZZI_COMMON + +config BOARD_GOOGLE_FENNEL + bool "-> Fennel" + select BOARD_GOOGLE_JACUZZI_COMMON
Tao Xia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44061 )
Change subject: mb/google/kukui: Add a new config 'Fennel' ......................................................................
Patch Set 1:
This change is ready for review.
Zhaoyou Hong has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44061 )
Change subject: mb/google/kukui: Add a new config 'Fennel' ......................................................................
Patch Set 1: Code-Review+1
Zhaoyou Hong has uploaded a new patch set (#2) to the change originally created by Tao Xia. ( https://review.coreboot.org/c/coreboot/+/44061 )
Change subject: mb/google/kukui: Add a new config 'Fennel' ......................................................................
mb/google/kukui: Add a new config 'Fennel'
A new board introduced to Kukui family.
BUG=b:162485230 TEST=make # select Fennel BRANCH=kukui
Signed-off-by: xiatao5 xiatao5@huaqin.corp-partner.google.com Change-Id: I1f742a36793f38c37fbd4e1b4cbddbd542e785ec --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/44061/2
Zhaoyou Hong has uploaded a new patch set (#3) to the change originally created by Tao Xia. ( https://review.coreboot.org/c/coreboot/+/44061 )
Change subject: mb/google/kukui: Add a new config 'Fennel' ......................................................................
mb/google/kukui: Add a new config 'Fennel'
A new board introduced to Kukui family.
BUG=b:162478693 TEST=make # select Fennel BRANCH=kukui
Signed-off-by: xiatao5 xiatao5@huaqin.corp-partner.google.com Change-Id: I1f742a36793f38c37fbd4e1b4cbddbd542e785ec --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/44061/3
Aaron Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44061 )
Change subject: mb/google/kukui: Add a new config 'Fennel' ......................................................................
Patch Set 3:
Hi Zhuohao, Can you help review or add someone to review it? thanks!
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44061 )
Change subject: mb/google/kukui: Add a new config 'Fennel' ......................................................................
Patch Set 3: Code-Review+1
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44061 )
Change subject: mb/google/kukui: Add a new config 'Fennel' ......................................................................
Patch Set 3: Code-Review+2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44061 )
Change subject: mb/google/kukui: Add a new config 'Fennel' ......................................................................
mb/google/kukui: Add a new config 'Fennel'
A new board introduced to Kukui family.
BUG=b:162478693 TEST=make # select Fennel BRANCH=kukui
Signed-off-by: xiatao5 xiatao5@huaqin.corp-partner.google.com Change-Id: I1f742a36793f38c37fbd4e1b4cbddbd542e785ec Reviewed-on: https://review.coreboot.org/c/coreboot/+/44061 Reviewed-by: Zhuohao Lee zhuohao@google.com Reviewed-by: Zhuohao Lee zhuohao@chromium.org Reviewed-by: Zhaoyou Hong hongzhaoyou@huaqin.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Zhuohao Lee: Looks good to me, approved Zhuohao Lee: Looks good to me, but someone else must approve Zhaoyou Hong: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 906dfea..e06e60f 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -57,6 +57,7 @@ default "Willow" if BOARD_GOOGLE_WILLOW default "Esche" if BOARD_GOOGLE_ESCHE default "Burnet" if BOARD_GOOGLE_BURNET + default "Fennel" if BOARD_GOOGLE_FENNEL
config DRIVER_TPM_SPI_BUS hex diff --git a/src/mainboard/google/kukui/Kconfig.name b/src/mainboard/google/kukui/Kconfig.name index ecfb86e..63cd3e7 100644 --- a/src/mainboard/google/kukui/Kconfig.name +++ b/src/mainboard/google/kukui/Kconfig.name @@ -57,3 +57,7 @@ config BOARD_GOOGLE_BURNET bool "-> Burnet" select BOARD_GOOGLE_JACUZZI_COMMON + +config BOARD_GOOGLE_FENNEL + bool "-> Fennel" + select BOARD_GOOGLE_JACUZZI_COMMON
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44061 )
Change subject: mb/google/kukui: Add a new config 'Fennel' ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44061/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44061/4//COMMIT_MSG@2 PS4, Line 2: xiatao5 Please use *Tao Xia* in the future.
-
Aaron Zhang (Code Review) -
Hung-Te Lin (Code Review)
-
Paul Menzel (Code Review)
-
Tao Xia (Code Review)
-
Zhaoyou Hong (Code Review)
-
Zhuohao Lee (Code Review)