Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/37386 )
Change subject: makechips.sh: Fix macOS compatibility ......................................................................
makechips.sh: Fix macOS compatibility
readlink -f does not exist on macOS (or other BSDs) as it is coreutils specific.
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Change-Id: Iad85cfadbd1a799f5dc7677d51cd2a2b773bd9fd --- M makechips.sh 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/86/37386/1
diff --git a/makechips.sh b/makechips.sh index d216442..cf908db 100755 --- a/makechips.sh +++ b/makechips.sh @@ -30,7 +30,7 @@
FILE=EM100Pro.msi TEMP=$(mktemp -d /tmp/makech.XXXXXX) -WD=$(readlink -f $(dirname $0)) +WD=$(cd "$(dirname `eval echo "$0"`)"; pwd) TD=$WD/em100_home
cd $TEMP
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37386 )
Change subject: makechips.sh: Fix macOS compatibility ......................................................................
Patch Set 1: Code-Review+2
Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/37386 )
Change subject: makechips.sh: Fix macOS compatibility ......................................................................
makechips.sh: Fix macOS compatibility
readlink -f does not exist on macOS (or other BSDs) as it is coreutils specific.
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Change-Id: Iad85cfadbd1a799f5dc7677d51cd2a2b773bd9fd Reviewed-on: https://review.coreboot.org/c/em100/+/37386 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: David Hendricks david.hendricks@gmail.com --- M makechips.sh 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved
diff --git a/makechips.sh b/makechips.sh index d216442..cf908db 100755 --- a/makechips.sh +++ b/makechips.sh @@ -30,7 +30,7 @@
FILE=EM100Pro.msi TEMP=$(mktemp -d /tmp/makech.XXXXXX) -WD=$(readlink -f $(dirname $0)) +WD=$(cd "$(dirname `eval echo "$0"`)"; pwd) TD=$WD/em100_home
cd $TEMP
-
David Hendricks (Code Review) -
Stefan Reinauer (Code Review)