Attention is currently required from: Patrick Rudolph, Paul Menzel.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78194?usp=email )
Change subject: cpu/intel/model_206ax: Only use supported C-states
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/cpu/intel/model_206ax/acpi.c:
https://review.coreboot.org/c/coreboot/+/78194/comment/2a02d726_5ef07a83 :
PS4, Line 161: acpigen_write_CST_package(acpi_cstate_map, count);
Just an idea for future.. if we create the exact same _CST for each thread, could we not replace it with a reference something like Return("\\CP00._CST") to reduce amount of ACPI table space?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78194?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaaee050e0ce3c29c12e97f5819a29f485a7946c2
Gerrit-Change-Number: 78194
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 06 Oct 2023 04:29:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment