Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: fix the memory interleaving options

[Mike Banon (Code Review)]

Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40532 )

Change subject: mb/asus/am1i-a/buildOpts.c: fix the memory interleaving options
......................................................................

mb/asus/am1i-a/buildOpts.c: fix the memory interleaving options

Fix the memory interleaving options in accordance with buildOpts.c
of the other AMD boards like Lenovo G505S and ASUS A88XM-E. Example:
if BLDCFG_MEMORY_ENABLE_NODE_INTERLEAVING is defined as FALSE
then BLDOPT_REMOVE_NODE_INTERLEAVE should be defined as TRUE.

Signed-off-by: Mike Banon 
Change-Id: Ib66e86d894c70e710ec67943c9d59c22108a7f2b
---
M src/mainboard/asus/am1i-a/buildOpts.c
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/40532/1

diff --git a/src/mainboard/asus/am1i-a/buildOpts.c b/src/mainboard/asus/am1i-a/buildOpts.c
index 71fedaa..48a9fe9 100644
--- a/src/mainboard/asus/am1i-a/buildOpts.c
+++ b/src/mainboard/asus/am1i-a/buildOpts.c
@@ -61,7 +61,7 @@
 #define BLDOPT_REMOVE_ECC_SUPPORT              TRUE
 //#define BLDOPT_REMOVE_BANK_INTERLEAVE          TRUE
 //#define BLDOPT_REMOVE_DCT_INTERLEAVE           TRUE
-//#define BLDOPT_REMOVE_NODE_INTERLEAVE          TRUE
+#define BLDOPT_REMOVE_NODE_INTERLEAVE          TRUE
 #define BLDOPT_REMOVE_PARALLEL_TRAINING        TRUE
 #define BLDOPT_REMOVE_ONLINE_SPARE_SUPPORT     TRUE
 //#define BLDOPT_REMOVE_MEM_RESTORE_SUPPORT      TRUE
@@ -108,9 +108,9 @@
 #define BLDCFG_MEMORY_RDIMM_CAPABLE               TRUE
 #define BLDCFG_MEMORY_UDIMM_CAPABLE               TRUE
 #define BLDCFG_MEMORY_SODIMM_CAPABLE              FALSE
-#define BLDCFG_MEMORY_ENABLE_BANK_INTERLEAVING    FALSE
+#define BLDCFG_MEMORY_ENABLE_BANK_INTERLEAVING    TRUE
 #define BLDCFG_MEMORY_ENABLE_NODE_INTERLEAVING    FALSE
-#define BLDCFG_MEMORY_CHANNEL_INTERLEAVING        FALSE
+#define BLDCFG_MEMORY_CHANNEL_INTERLEAVING        TRUE
 #define BLDCFG_MEMORY_POWER_DOWN                  TRUE
 #define BLDCFG_POWER_DOWN_MODE                    POWER_DOWN_BY_CHIP_SELECT
 #define BLDCFG_ONLINE_SPARE                       FALSE

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40532 )

Change subject: mb/asus/am1i-a/buildOpts.c: fix the memory interleaving options
......................................................................

Patch Set 1: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40532 )

Change subject: mb/asus/am1i-a/buildOpts.c: fix the memory interleaving options
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40532/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40532/1//COMMIT_MSG@13 
PS1, Line 13: 
Does the binary actually change?

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40532 )

Change subject: mb/asus/am1i-a/buildOpts.c: fix the memory interleaving options
......................................................................

Patch Set 1:

is this tested on hardware?

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40532 )

Change subject: mb/asus/am1i-a/buildOpts.c: fix the memory interleaving options
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40532/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40532/1//COMMIT_MSG@13 
PS1, Line 13:
> Does the binary actually change?

It does change, because some settings are enabled.

[Mike Banon (Code Review)]

Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40532 )

Change subject: mb/asus/am1i-a/buildOpts.c: fix the memory interleaving options
......................................................................

Abandoned

Memory interleaving options are already fixed at the new version of ./src/vendorcode/amd/agesa/f16kb/Config/PlatformInstall.h (BANK and DCT - TRUE, NODE - FALSE) for all f16kb boards including AM1I-A, so this change is not needed anymore.