Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36686 )
Change subject: include/device: add pci mmio cfg address helpers
......................................................................
Patch Set 4:
Patch Set 4:
Sorry I did not spot this before merge. Which commit is this used in, I'd like to see the use case.
I quess I would like to see that the address return here does not get permanently stored anywhere.
No, it does not (would there be any reason for doing that?). For the use case see CB:36569.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36686
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6fe22cacc7241a51d47cbe9fc64f30fa49d5a80
Gerrit-Change-Number: 36686
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 11 Nov 2019 17:11:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment