Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44818 )
Change subject: util/ifdtool: Add FLMAP3 dump for Gen11 onwards PCH ......................................................................
util/ifdtool: Add FLMAP3 dump for Gen11 onwards PCH
BUG=b:153888802 TEST=Able to dump FLMAP3 for Volteer platform with TGP
ifdtool -d coreboot.rom
FLMAP3: 0x00000000 Minor Revision ID: 0x0000 Major Revision ID: 0x0000
Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: I681abd6ae7b87f6638d4f6dc59168cf22b93c787 --- M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h 2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/44818/1
diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 4de1205..ac86441 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -813,6 +813,12 @@ printf(" FMSBA: 0x%x\n", ((fdb->flmap2) & 0xff) << 4); }
+ if (chipset == CHIPSET_500_SERIES_TIGER_POINT) { + printf("FLMAP3: 0x%08x\n", fdb->flmap3); + printf(" Minor Revision ID: 0x%04x\n", (fdb->flmap3 >> 14) & 0x7f); + printf(" Major Revision ID: 0x%04x\n", (fdb->flmap3 >> 21) & 0x7ff); + } + char *flumap = find_flumap(image, size); uint32_t flumap1 = *(uint32_t *)flumap; printf("FLUMAP1: 0x%08x\n", flumap1); diff --git a/util/ifdtool/ifdtool.h b/util/ifdtool/ifdtool.h index a113d29..fb3de2f 100644 --- a/util/ifdtool/ifdtool.h +++ b/util/ifdtool/ifdtool.h @@ -81,6 +81,7 @@ uint32_t flmap0; uint32_t flmap1; uint32_t flmap2; + uint32_t flmap3; // Exist for 500 series onwards } __attribute__((packed)) fdbar_t;
// regions
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44818 )
Change subject: util/ifdtool: Add FLMAP3 dump for Gen11 onwards PCH ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44818 )
Change subject: util/ifdtool: Add FLMAP3 dump for Gen11 onwards PCH ......................................................................
util/ifdtool: Add FLMAP3 dump for Gen11 onwards PCH
BUG=b:153888802 TEST=Able to dump FLMAP3 for Volteer platform with TGP
ifdtool -d coreboot.rom
FLMAP3: 0x00000000 Minor Revision ID: 0x0000 Major Revision ID: 0x0000
Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: I681abd6ae7b87f6638d4f6dc59168cf22b93c787 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44818 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h 2 files changed, 7 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 93f29d4..56e05fe 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -811,6 +811,12 @@ printf(" FMSBA: 0x%x\n", ((fdb->flmap2) & 0xff) << 4); }
+ if (chipset == CHIPSET_500_SERIES_TIGER_POINT) { + printf("FLMAP3: 0x%08x\n", fdb->flmap3); + printf(" Minor Revision ID: 0x%04x\n", (fdb->flmap3 >> 14) & 0x7f); + printf(" Major Revision ID: 0x%04x\n", (fdb->flmap3 >> 21) & 0x7ff); + } + char *flumap = find_flumap(image, size); uint32_t flumap1 = *(uint32_t *)flumap; printf("FLUMAP1: 0x%08x\n", flumap1); diff --git a/util/ifdtool/ifdtool.h b/util/ifdtool/ifdtool.h index a113d29..fb3de2f 100644 --- a/util/ifdtool/ifdtool.h +++ b/util/ifdtool/ifdtool.h @@ -81,6 +81,7 @@ uint32_t flmap0; uint32_t flmap1; uint32_t flmap2; + uint32_t flmap3; // Exist for 500 series onwards } __attribute__((packed)) fdbar_t;
// regions
-
Patrick Georgi (Code Review) -
Subrata Banik (Code Review)
-
Tim Wawrzynczak (Code Review)