[S] Change in coreboot[master]: mb/google/brya/variants/volmar: Add firmware config field for FP_MCU - coreboot-gerrit

3 Nov 2022


      Attention is currently required from: Ofer Fried, Tim Wawrzynczak.
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68917 )
Change subject: mb/google/brya/variants/volmar: Add firmware config field for FP_MCU
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
...
Ofer, does this change need to go into the config. […]
Hi Ofer,
In config.star, we have already set the FP enable/disable by SKU ID.
But from our testing, the "seconds_power_on_to_login" will be improved on the test firmware (close the FP). Suppose that disable FP in config.star can not skip the initial FP process if the ASL code set the FP enable.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/68917
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I867771904811459697056662d5e29c545a1a9474
Gerrit-Change-Number: 68917
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Ofer Fried oferfried@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paz Zcharya pazz@google.com
Gerrit-Attention: Ofer Fried oferfried@google.com
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Comment-Date: Thu, 03 Nov 2022 02:28:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro nvaccaro@google.com
Gerrit-MessageType: comment