Attention is currently required from: Martin Roth, Marshall Dawson, Kangheui Won, Paul Menzel, Zheng Bao, Eric Peers, Karthikeyan Ramasubramanian.
Hello build bot (Jenkins), Martin Roth, Marshall Dawson, Kangheui Won, Zheng Bao, Karthikeyan Ramasubramanian, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56438
to look at the new patch set (#15).
Change subject: amdfwtool: Use relative address for EFS gen2
......................................................................
amdfwtool: Use relative address for EFS gen2
The second generation EFS (offset 0x24[0]=0) uses
"binary relative" offsets and not "x86 physical
MMIO address" like gen1.
Chips like Cezanne can run in both cases, so no problem
comes up so far.
The related change in psp_verstage has been uploaded.
https://review.coreboot.org/c/coreboot/+/58316
BUG=b:188754219
Test=Majolica (Cezanne)
Change-Id: I7701c7819f03586d4ecab3d744056c8c902b630f
Signed-off-by: Zheng Bao fishbaozi@gmail.com
---
M util/amdfwtool/amdfwtool.c
M util/amdfwtool/amdfwtool.h
2 files changed, 22 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/56438/15
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56438
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7701c7819f03586d4ecab3d744056c8c902b630f
Gerrit-Change-Number: 56438
Gerrit-PatchSet: 15
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bao Zheng
zheng.bao@amd.corp-partner.google.com
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-MessageType: newpatchset