Attention is currently required from: Furquan Shaikh, Subrata Banik, Ronak Kanabar, Andrey Petrov, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57343 )
Change subject: drivers/intel/fsp2_0: Allow `mp_startup_all_cpus()` to run serially
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57343/comment/48af61f2_dc480abb
PS1, Line 17: But another MP service API `StartupAllCPUs` doesn't specifies any such
: requirement. Running the `func` simultaneously on APs results into
: coherency issue due to lack of acquire spin lock while accessing common
: data structure in multiprocessor environment.
It's hard to figure out if this is called out explicitly anywhere... is this defined somewhere, or is this FSP behavior?
Is this causing any known issues?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia95d11408f663212fd40daa9fd9b0881a07f1ce7
Gerrit-Change-Number: 57343
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 02 Sep 2021 22:48:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment