[S] Change in coreboot[master]: cpu/intel/car/romstage: Clear graphics before exiting romstage

[Angel Pons (Code Review)]

Attention is currently required from: Bora Guvendik, Zhixing Ma, Anil Kumar K, Hannah Williams, Cliff Huang, Tarun Tuli, Nico Huber, Michał Żygowski, Jérémy Compostella, Paul Menzel, Arthur Heymans.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70302 )

Change subject: cpu/intel/car/romstage: Clear graphics before exiting romstage
......................................................................

Patch Set 35: Code-Review+1

(2 comments)

File src/cpu/intel/car/romstage.c:

https://review.coreboot.org/c/coreboot/+/70302/comment/6358e000_33069cd5 
PS22, Line 72: #if CONFIG(SOC_INTEL_COMMON_BLOCK_GRAPHICS)
> Thanks.  Didn't realize it was a issue of not finding the header, rather than the function itself. […]

If you always provide the declaration for `early_graphics_stop()`, you can remove the preprocessor guards. The problem is that the included header is in the `soc/intel/` namespace. As the functionality seems quite generic (one could implement these functions for an Aspeed BMC too, for instance), it would make sense to move the header to `drivers/gfx/early_graphics.h` or similar.

File src/cpu/intel/car/romstage.c:

https://review.coreboot.org/c/coreboot/+/70302/comment/c90e54d8_9b555939 
PS35, Line 14: #if CONFIG(SOC_INTEL_COMMON_BLOCK_GRAPHICS)
You should remove this guard to remove the other guards.