Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37651 )
Change subject: mainboard/variant/puff: set PL values for puff ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37651/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37651/1/src/mainboard/google/hatch/... PS1, Line 16: variant.c
mainboard. […]
Ack
https://review.coreboot.org/c/coreboot/+/37651/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/variant.c:
https://review.coreboot.org/c/coreboot/+/37651/1/src/mainboard/google/hatch/... PS1, Line 1: /*
call this file mainboard. […]
Ack
https://review.coreboot.org/c/coreboot/+/37651/1/src/mainboard/google/hatch/... PS1, Line 66: pl4 = 0;
lets not block on this.
Ack
-
Kangheui Won (Code Review)